astute.yaml became unreadable

[Sergey Vasilenko]

Detailed bug description:
While 9.0 release cycle astute.yaml file format changed.

Steps to reproduce:
# less /etc/astute.yaml
on any node, except master

Actual result:
cluster:
  changes:
  - {name: interfaces, node_id: 14}
  - {name: interfaces, node_id: 15}
  - {name: interfaces, node_id: 16}

Expected results:
cluster:
  changes:
  - name: interfaces
    node_id: 14
  - name: interfaces
    node_id: 15
  - name: interfaces
    node_id: 16

Reproducibility:
100%

Workaround:
No

Impact:
  * new curent format is heavy for human-readability
  * Custom utilities, which require pure yaml format may not work properly

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/320550

[Ihor Kalnytskyi (ikalnytskyi)]

Both are valid and readable YAMLs. The fix MUST BE done on library side. We CAN'T control serialization format on YAML. We can TEMPORARILY rely that some flag will produce something that works for us, but it's not a fix and won't last forever.

[Ihor Kalnytskyi (ikalnytskyi)]

Taking into account that *custom utilities* is not our case since we produce a valid YAML, I change bug priority to Medium and set Won't Fix for 9.0.

[Alexey Shtokolov (ashtokolov)]

Both are valid but the current is not enough readable. It makes ugly UX for deployment engineers.

  Previously we had the convenient format. Afair we choose YAML instead of JSON to increase the readability. I suggest to keep it.

[Sergey Vasilenko (xenolog)]

Taking into account that new format became less human readable and trivial fix ready, I increase bug priority.

De-facto, astute.yaml purpose is not only software-to-sowtware exchange. Deployment engineers, who on-site, often read and analyze content of this file.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/320550
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=bdf612bf437f9b856dccbbc34e142319979b98af
Submitter: Jenkins
Branch: master

commit bdf612bf437f9b856dccbbc34e142319979b98af
Author: Bulat Gaifullin <email address hidden>
Date: Tue May 24 18:48:25 2016 +0300

    Disable 'default_flow_style' for yaml.dump

    If this option is False,
    the collections is always serialized in the block style.

    Change-Id: I8e8d7cc1773b8c20968ff526110387a0590690b1
    Closes-Bug: 1585271

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/323023

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/323023
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=ca81ebc8e7eada1fd0865f2f919df910f6d845e6
Submitter: Jenkins
Branch: stable/mitaka

commit ca81ebc8e7eada1fd0865f2f919df910f6d845e6
Author: Bulat Gaifullin <email address hidden>
Date: Tue May 24 18:48:25 2016 +0300

    Disable 'default_flow_style' for yaml.dump

    If this option is False,
    the collections is always serialized in the block style.

    Change-Id: I8e8d7cc1773b8c20968ff526110387a0590690b1
    Closes-Bug: 1585271
    (cherry picked from commit bdf612bf437f9b856dccbbc34e142319979b98af)

[Grigory Mikhailov (gmikhailov)]

Verified on #fuel-9.0-mos-450 iso.
astute.yaml file format is human readable.

[root@nailgun ~]# shotgun2 short-report
cat /etc/fuel_build_id: 450
cat /etc/fuel_build_number: 450
cat /etc/fuel_release: 9.0
cat /etc/fuel_openstack_version: mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-release-9.0.0-1.mos6347.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8723.noarch
 python-packetary-9.0.0-1.mos140.noarch
 fuel-bootstrap-cli-9.0.0-1.mos285.noarch
 fuel-migrate-9.0.0-1.mos8435.noarch
 rubygem-astute-9.0.0-1.mos748.noarch
 fuel-mirror-9.0.0-1.mos140.noarch
 shotgun-9.0.0-1.mos90.noarch
 fuel-openstack-metadata-9.0.0-1.mos8723.noarch
 fuel-notify-9.0.0-1.mos8435.noarch
 nailgun-mcagents-9.0.0-1.mos748.noarch
 python-fuelclient-9.0.0-1.mos323.noarch
 fuel-9.0.0-1.mos6347.noarch
 fuel-utils-9.0.0-1.mos8435.noarch
 fuel-setup-9.0.0-1.mos6347.noarch
 fuel-misc-9.0.0-1.mos8435.noarch
 fuel-library9.0-9.0.0-1.mos8435.noarch
 network-checker-9.0.0-1.mos74.x86_64
 fuel-agent-9.0.0-1.mos285.noarch
 fuel-ui-9.0.0-1.mos2715.noarch
 fuel-ostf-9.0.0-1.mos935.noarch
 fuelmenu-9.0.0-1.mos272.noarch
 fuel-nailgun-9.0.0-1.mos8723.noarch