Load deployed button doesn't work if plugin was installed after deployment

[Volodymyr Shypyguzov]

Steps to reproduce:
1.Setup master node
2.Create a new env
3.Go to the settings tab. Make some changes to make a config different rather than the default one.
4.Keep in mind all changes
5.Deploy the environment
5.1 Install any plugin on fuel master, for instance:
fuel plugins --install fuel_plugin_example_v4_hotpluggable-4.0-4.0.0-1.noarch.rpm
6.Go to the settings tab and make some changes.
7.Press Load Deployed button.
8.Settings should be changed to deployed state and be equal to settings on the step 3

Actual result: Setting are not reverted
Expected result: Settings are reverted to the deployed state

In JS log:
TypeError: setting is undefined

Clicking any settings tab ends up with error:
TypeError: section.metadata is undefined and whole Settings becomes unresponsible

Env info:
[root@nailgun ~]# shotgun2 short-report
cat /etc/fuel_build_id:
 376
cat /etc/fuel_build_number:
 376
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-release-9.0.0-1.mos6346.noarch
 fuel-bootstrap-cli-9.0.0-1.mos281.noarch
 fuel-migrate-9.0.0-1.mos8376.noarch
 rubygem-astute-9.0.0-1.mos745.noarch
 fuel-misc-9.0.0-1.mos8376.noarch
 network-checker-9.0.0-1.mos72.x86_64
 fuel-mirror-9.0.0-1.mos136.noarch
 fuel-openstack-metadata-9.0.0-1.mos8693.noarch
 fuel-notify-9.0.0-1.mos8376.noarch
 nailgun-mcagents-9.0.0-1.mos745.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8693.noarch
 python-fuelclient-9.0.0-1.mos315.noarch
 fuelmenu-9.0.0-1.mos270.noarch
 fuel-9.0.0-1.mos6346.noarch
 fuel-utils-9.0.0-1.mos8376.noarch
 fuel-setup-9.0.0-1.mos6346.noarch
 fuel-library9.0-9.0.0-1.mos8376.noarch
 shotgun-9.0.0-1.mos88.noarch
 fuel-agent-9.0.0-1.mos281.noarch
 fuel-ui-9.0.0-1.mos2688.noarch
 fuel-ostf-9.0.0-1.mos934.noarch
 python-packetary-9.0.0-1.mos136.noarch
 fuel-nailgun-9.0.0-1.mos8693.noarch

[Julia Aranovich (jkirnosova)]

The issue is in plugin settings:
environment has some plugins installed (activated or not), their data comes into GET /api/clusters/x/attributes response. But after deployment, the plugins data is not included into GET /api/clusters/x/attributes/deployed response, which is processed by UI after Load Deployed button click.

[Volodymyr Shypyguzov (vshypyguzov)]

After deeper investigation I've found that it doesn't work only if plugin was installed after deployment of environment

[Julia Aranovich (jkirnosova)]

According to this new fact, deployed cluster configuration comes from backend in a valid state.
Fuel UI code should take into account that some plugins can not exist in this response.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/321612

[Alexey. Kalashnikov (akalashnikov)]

Seems like this trouble, also affects on discarding changes by button on "Dashboard" tab.

Another scenario:
1.Setup master node
2.Create a new env
3.Go to the settings tab. Make some changes to make a config different rather than the default one.
4.Keep in mind all changes
5.Deploy the environment
5.1 Install any plugin on fuel master, for instance:
fuel plugins --install fuel_plugin_example_v4_hotpluggable-4.0-4.0.0-1.noarch.rpm
6.Go to the settings tab and turn on the plugin in "Other" section.
7.Then go to the dashboard tab and discard changes, via clicking on "cross" button, near configuration changes in list.

Actual result: nothing happened, changes were not discarded.
Expected result: configuration changes were discarded, "Deploy changes" button has disappeared, plugin was turned off

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/321612
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=f6efa20b979742f86257ff7e393819c13b6f321f
Submitter: Jenkins
Branch: master

commit f6efa20b979742f86257ff7e393819c13b6f321f
Author: Julia Aranovich <email address hidden>
Date: Thu May 26 18:19:01 2016 +0300

    Fix resetting of cluster settings

    Uploading of deployed settings should not remove
    plugins installed after deployment.

    Closes-Bug: #1584703

    Change-Id: If6911b14aab78d26d5413380f51ed137f8eef01a

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/322661

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/322661
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=5c333dd3acc7177b1d0435853788063e57f30879
Submitter: Jenkins
Branch: stable/mitaka

commit 5c333dd3acc7177b1d0435853788063e57f30879
Author: Julia Aranovich <email address hidden>
Date: Thu May 26 18:19:01 2016 +0300

    Fix resetting of cluster settings

    Uploading of deployed settings should not remove
    plugins installed after deployment.

    Closes-Bug: #1584703

    Change-Id: If6911b14aab78d26d5413380f51ed137f8eef01a

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/322844

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/322870

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/322844
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=f35effe23d439302929c6660082067547d7f6d63
Submitter: Jenkins
Branch: master

commit f35effe23d439302929c6660082067547d7f6d63
Author: Julia Aranovich <email address hidden>
Date: Mon May 30 17:19:50 2016 +0300

    Fix setting defaults uploading

    Loading of environment settings' defaults is asynchronous
    operation. Auxiliary settingsForChecks model should be updated
    right after loading default data to the main settings model.

    Partial-Bug: #1584703

    Change-Id: I3c9ebaf66e4c359ee52e3f5248bc93ba2efb0169

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/322870
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=3d1391bf806fa3eae1a45763d433213cf84bf6b1
Submitter: Jenkins
Branch: stable/mitaka

commit 3d1391bf806fa3eae1a45763d433213cf84bf6b1
Author: Julia Aranovich <email address hidden>
Date: Mon May 30 17:19:50 2016 +0300

    Fix setting defaults uploading

    Loading of environment settings' defaults is asynchronous
    operation. Auxiliary settingsForChecks model should be updated
    right after loading default data to the main settings model.

    Partial-Bug: #1584703

    Change-Id: I3c9ebaf66e4c359ee52e3f5248bc93ba2efb0169

[Grigory Mikhailov (gmikhailov)]

Verified on #fuel-9.0-mos-429 iso.
Settings are reverted to the deployed state.

[root@nailgun ~]# shotgun2 short-report
cat /etc/fuel_build_id: 429
cat /etc/fuel_build_number: 429
cat /etc/fuel_release: 9.0
cat /etc/fuel_openstack_version: mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-release-9.0.0-1.mos6347.noarch
 fuel-misc-9.0.0-1.mos8420.noarch
 fuel-bootstrap-cli-9.0.0-1.mos284.noarch
 fuel-migrate-9.0.0-1.mos8420.noarch
 rubygem-astute-9.0.0-1.mos748.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8718.noarch
 network-checker-9.0.0-1.mos72.x86_64
 fuel-mirror-9.0.0-1.mos137.noarch
 fuel-openstack-metadata-9.0.0-1.mos8718.noarch
 fuel-notify-9.0.0-1.mos8420.noarch
 nailgun-mcagents-9.0.0-1.mos748.noarch
 python-fuelclient-9.0.0-1.mos319.noarch
 fuelmenu-9.0.0-1.mos270.noarch
 fuel-9.0.0-1.mos6347.noarch
 fuel-utils-9.0.0-1.mos8420.noarch
 fuel-setup-9.0.0-1.mos6347.noarch
 fuel-library9.0-9.0.0-1.mos8420.noarch
 shotgun-9.0.0-1.mos90.noarch
 fuel-agent-9.0.0-1.mos284.noarch
 fuel-ui-9.0.0-1.mos2710.noarch
 fuel-ostf-9.0.0-1.mos934.noarch
 python-packetary-9.0.0-1.mos137.noarch
 fuel-nailgun-9.0.0-1.mos8718.noarch