Validation message for number of SR-IOV virtual functions is inaccurate

[Mikhail Chernik]

Environment: MOS 9.0 ISO 370

Description:

When number of enabled SR-IOV Virtual Functions on Interface configuration screen is not valid, error message suggests the number should be less than maximum number of VFs instead of maximum number plus one.

For example Intel 82599 supports up to 63 virtual functions, so allowed value should be less then 64, not 63.

See attached screen-shots for details

Steps to reproduce:

1) Install Fuel and create cluster
2) Add a node with network card which supports SR-IOV
3) Click configure interface for that node, turn on SR-IOV for the interface
4) Delete value from 'Number of Virtual Functions' input field

Expected result:
message 'Virtual Functions number should be a positive number less than <MAX VF number+1>' is displayed

Actual result:
message 'Virtual Functions number should be a positive number less than <MAX VF number>' is displayed

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/330428

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/330428
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=c9c02c744b5522d5bd260f2b6f2d3f9254958e9f
Submitter: Jenkins
Branch: master

commit c9c02c744b5522d5bd260f2b6f2d3f9254958e9f
Author: Kate Pimenova <email address hidden>
Date: Thu Jun 16 13:00:43 2016 +0300

    Validation message for number of SR-IOV is fixed

    Closes-Bug: #1583187

    Change-Id: I118eead649fed4d1f927da541302066f2fe19c5b