The previous states should not be used for the context evaluation if there was no successful deployment after last provisioning

Bug #1582269 reported by Arthur Svechnikov
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Nikita Zubkov
Mitaka
Fix Released
High
Nikita Zubkov
Newton
Fix Committed
High
Nikita Zubkov

Bug Description

Detailed bug description:
 Currently, transactions are not deleted after node re-provision or cluster reset. It's lead to incorrect transaction processing. In fact, a node shouldn't have any deployment history. Otherwise, it's highly possible that deployment won't work at all.
Steps to reproduce:
 1. Deploy 1 controller
 2. Re-provision controller
 3. Deploy controller
 4. Stop deploy
 5. Resume deploy
Expected results:
 All steps are passed
Actual result:
 Step 5 failed due to inconsistency of transactions
Workaround:
 Don't use stop deploy

Changed in fuel:
milestone: none → 10.0
Revision history for this message
Bug Checker Bot (bug-checker) wrote : Autochecker

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

version

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

tags: added: need-info
Revision history for this message
Alexey Shtokolov (ashtokolov) wrote : Re: Transactions are not deleted after re-install or cluster reset

The root cause: we shouldn't use a context for deployment if there was no successful deployment after last provisioning.

summary: - Transactions are not deleted after re-install or cluster reset
+ The previous states should not be used for context evaluation if there
+ was no successful deployment after last provisioning
summary: - The previous states should not be used for context evaluation if there
- was no successful deployment after last provisioning
+ The previous states should not be used for the context evaluation if
+ there was no successful deployment after last provisioning
Dmitry Pyzhov (dpyzhov)
tags: added: area-python
Revision history for this message
Nikita Zubkov (zubchick) wrote :
Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/317614
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=5ba7416156786e6d409c6f3a969441b55c2ea2bb
Submitter: Jenkins
Branch: master

commit 5ba7416156786e6d409c6f3a969441b55c2ea2bb
Author: Nikita Zubkov <email address hidden>
Date: Tue May 17 19:10:02 2016 +0300

    Fix getting previous state for deployment

    Now we get last success transaction not only for every task but for
    every node in the cluster. The previous version of state collecting
    function may lead to false-positive choice of previous deployment
    transaction and issues with smart YAQL-based redeployment.

    Change-Id: If9e22924acb465487a2fa97534fe50f03a1590a1
    Closes-Bug: #1581015
    Closes-Bug: #1582269

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/320329

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/320329
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=48cb2465e0e04b8a6fb03b740560be929dd2a75f
Submitter: Jenkins
Branch: stable/mitaka

commit 48cb2465e0e04b8a6fb03b740560be929dd2a75f
Author: Nikita Zubkov <email address hidden>
Date: Tue May 17 19:10:02 2016 +0300

    Fix getting previous state for deployment

    Now we get last success transaction not only for every task but for
    every node in the cluster. The previous version of state collecting
    function may lead to false-positive choice of previous deployment
    transaction and issues with smart YAQL-based redeployment.

    Change-Id: If9e22924acb465487a2fa97534fe50f03a1590a1
    Closes-Bug: #1581015
    Closes-Bug: #1582269
    (cherry picked from commit 5ba7416156786e6d409c6f3a969441b55c2ea2bb)

tags: added: on-verification
Revision history for this message
Alisa Tselovalnikova (atselovalnikova) wrote :

Verified on http://paste.openstack.org/show/516534.
All steps are passed.

tags: removed: on-verification
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.