Fuel for OpenStack

Scaling of deployed cluster leads to "second argument must be a hash at /etc/puppet/modules/osnailyfacter/manifests/hosts/hosts.pp:21"

Bug #1582263 reported by Vladimir Khlyunev on 2016-05-16

This bug affects 2 people

	Status	Importance	Assigned to	Milestone
Fuel for OpenStack	Fix Released	High	Alex Schultz	Fuel for OpenStack 10.0
Mitaka	Fix Released	High	Matthew Mosesohn	Fuel for OpenStack 9.0
Newton	Fix Released	High	Alex Schultz	Fuel for OpenStack 10.0

Bug Description

Several swarm tests failed:
https://product-ci.infra.mirantis.net/job/9.0.system_test.ubuntu.ha_neutron_tun/108/

ISO 9.0 mos - 362
Snapshot https://product-ci.infra.mirantis.net/job/9.0.system_test.ubuntu.ha_neutron_tun/108/artifact/logs/fail_error_neutron_tun_ha_addremove-fuel-snapshot-2016-05-15_02-38-54.tar.xz

Steps to reproduce:
        1. Revert snapshot deploy_neutron_tun_ha with 3 controller
           and 2 compute nodes
        2. Add 'cinder' role to a new slave
        3. Deploy changes
        4. Remove the 'cinder' node
           Remove a 'controller' node
           Add 'controller'+'cinder' multirole to a new slave
        5. Deploy changes

Actual result:
task "hosts" failed on all nodes with:
err: create_resources(): second argument must be a hash at /etc/puppet/modules/osnailyfacter/manifests/hosts/hosts.pp:21

Swarm blocker because it affects at least 4 tests

Tags:

Revision history for this message

Bug Checker Bot (bug-checker) wrote on 2016-05-16: Autochecker

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

expected result

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

tags:

added: need-info

Alex Schultz (alex-schultz) on 2016-05-16

Changed in fuel:
status:	New → Confirmed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-16: Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/317025

Changed in fuel:
assignee:	Fuel Sustaining (fuel-sustaining-team) → Alex Schultz (alex-schultz)
status:	Confirmed → In Progress

Revision history for this message

Matthew Mosesohn (raytrac3r) wrote on 2016-05-17:

Stealing this because this is a swarm blocker

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-17: Fix proposed to fuel-library (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/317584

OpenStack Infra (hudson-openstack) on 2016-05-17

Changed in fuel:
assignee:	Matthew Mosesohn (raytrac3r) → Alex Schultz (alex-schultz)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-18: Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/317025
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=643619f9c66be4bf4a33f23fc7af7b714048a58f
Submitter: Jenkins
Branch: master

commit 643619f9c66be4bf4a33f23fc7af7b714048a58f
Author: Alex Schultz <email address hidden>
Date: Mon May 16 11:43:56 2016 -0600

Fix call to ensure deleted nodes are deleted from /etc/hosts

    The create_resources function needs a hash provided to it and we
    currently store deleted nodes as an array of strings. This change
    updates the logic to use ensure_resource(), which accepts an
    array of host titles.

Change-Id: I6f6b87db71c93347a46fa543ed0c18ef8b102394
Closes-Bug: #1582263