UI prohibits to remove plugin and plugin's nodes simultaneously

[Alexey Shtokolov]

Version: Fuel 9.0 build 285

Steps to reproduce:
 Create cluster
 Install plugins (e.g. 4 LMA plugins)
 Turn on and configure plugins for the cluster
 Add nodes (incl. node with plugins' roles)
 Deploy changes
 Remove node with plugins' roles (mark as PENDING DELETION)
 Try to turn off the plugins

Expected results:
 UI allows to turn off the plugin

Actual result:
 UI prohibits to turn off the plugins with warning that the environment contains plugins' node (Node with plugins' roles is marked as PENDING DELETION)

[Alexey Shtokolov (ashtokolov)]

The same case with ceilometer and mongo nodes

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/316087

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/317626

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/317626
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=39b6c71f5a82583f0d5cca0d5a55b91b83b0f909
Submitter: Jenkins
Branch: stable/mitaka

commit 39b6c71f5a82583f0d5cca0d5a55b91b83b0f909
Author: Julia Aranovich <email address hidden>
Date: Fri May 13 16:19:30 2016 +0300

    Fix calculation of role dependency for environment settings

    User should be able to turn off a setting if there are no deployed
    or ready for deployment nodes in environment with a role,
    which depends on this setting.

    Closes-Bug: #1581506

    Change-Id: I732c6b64a7cd90b73162789231255c29006bb21f

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/316087
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=f7aedfc0542cb9aa163183d7f45854dfb2303606
Submitter: Jenkins
Branch: master

commit f7aedfc0542cb9aa163183d7f45854dfb2303606
Author: Julia Aranovich <email address hidden>
Date: Fri May 13 16:19:30 2016 +0300

    Fix calculation of role dependency for environment settings

    User should be able to turn off a setting if there are no deployed
    or ready for deployment nodes in environment with a role,
    which depends on this setting.

    Closes-Bug: #1581506

    Change-Id: I732c6b64a7cd90b73162789231255c29006bb21f

[Alexey. Kalashnikov (akalashnikov)]

Verified on 9.0-417-mos: Now user can turn off installed plugin on "other" settings page, in cases nodes dependent on the plugin are pending to deletion or no nodes ready to deploy with plugin roles.
[root@nailgun ~]# shotgun2 short-report
cat /etc/fuel_build_id:
 417
cat /etc/fuel_build_number:
 417
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-release-9.0.0-1.mos6347.noarch
 fuel-bootstrap-cli-9.0.0-1.mos284.noarch
 fuel-migrate-9.0.0-1.mos8398.noarch
 fuel_plugin_example_v4-4.0-4.0.0-1.noarch
 rubygem-astute-9.0.0-1.mos746.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8709.noarch
 network-checker-9.0.0-1.mos72.x86_64
 fuel-mirror-9.0.0-1.mos137.noarch
 fuel-openstack-metadata-9.0.0-1.mos8709.noarch
 fuel-notify-9.0.0-1.mos8398.noarch
 nailgun-mcagents-9.0.0-1.mos746.noarch
 python-fuelclient-9.0.0-1.mos316.noarch
 fuelmenu-9.0.0-1.mos270.noarch
 fuel-9.0.0-1.mos6347.noarch
 fuel-utils-9.0.0-1.mos8398.noarch
 fuel-setup-9.0.0-1.mos6347.noarch
 fuel-library9.0-9.0.0-1.mos8398.noarch
 shotgun-9.0.0-1.mos90.noarch
 fuel-agent-9.0.0-1.mos284.noarch
 fuel-ui-9.0.0-1.mos2706.noarch
 fuel-ostf-9.0.0-1.mos934.noarch
 fuel-misc-9.0.0-1.mos8398.noarch
 python-packetary-9.0.0-1.mos137.noarch
 fuel-nailgun-9.0.0-1.mos8709.noarch