puppetmaster package have different init script with upstream

Bug #1581247 reported by Alexander Noskov on 2016-05-12
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
High
Alexander Noskov

Bug Description

Detailed bug description:
We have manifest which is installing puppetmaster package.
During the deployment we are stopping puppetmaster service, but each puppet apply, it tries to stop service again, but service is already stopped.

For example:
root@node-3:~# cat test.pp
service { 'puppetmaster':
ensure => stopped,
enable => false,
}
root@node-3:~# puppet apply test.pp
Notice: Compiled catalog for node-3.test.domain.local in environment production in 0.25 seconds
Notice: /Stage[main]/Main/Service[puppetmaster]/ensure: ensure changed 'running' to 'stopped'
Notice: Finished catalog run in 0.49 seconds
root@node-3:~# service puppetmaster status
 * master is not running
root@node-3:~# echo $?
3
root@node-3:~# puppet apply test.pp
Notice: Compiled catalog for node-3.test.domain.local in environment production in 0.27 seconds
Notice: /Stage[main]/Main/Service[puppetmaster]/ensure: ensure changed 'running' to 'stopped'
Notice: Finished catalog run in 0.54 seconds

root@node-3:~# apt-cache policy puppetmaster
puppetmaster:
  Installed: 3.8.5-2~u14.04+mos1
  Candidate: 3.8.5-2~u14.04+mos1

If I am using upstream init script from 3.8.5 branch, it works well.
Attached diff of init script from package with upstream init script

Alexander Noskov (anoskov) wrote :
Maciej Relewicz (rlu) on 2016-05-13
Changed in fuel:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Fuel build team (fuel-build)
milestone: none → 10.0
tags: added: area-build
Roman Vyalov (r0mikiam) wrote :

reassign to mos team. because its linux package.

Changed in fuel:
status: Confirmed → New
assignee: Fuel build team (fuel-build) → MOS Linux (mos-linux)
tags: added: area-mos
removed: area-build
Maciej Relewicz (rlu) on 2016-05-13
Changed in fuel:
status: New → Confirmed

Fix proposed to branch: master
Change author: Ivan Suzdal <email address hidden>
Review: https://review.fuel-infra.org/20635

Changed in fuel:
status: Confirmed → In Progress
Ivan Suzdal (isuzdal) on 2016-05-13
Changed in fuel:
assignee: MOS Linux (mos-linux) → Ivan Suzdal (isuzdal)

Reviewed: https://review.fuel-infra.org/20635
Submitter: Pkgs Jenkins <email address hidden>
Branch: master

Commit: b5ded87fa0874018605055c4b5c7c43af29ab9b0
Author: Ivan Suzdal <email address hidden>
Date: Fri May 13 09:57:36 2016

Add "--masterport" key to start_puppet_master function
in puppetmaster init script.

Also made some cosmetic fixes which make init script
more readable.

Change-Id: If28a02c142059a9d28d780ce1091e6f423c7d288
Closes-Bug: #1581247

Changed in fuel:
status: In Progress → Fix Committed
Ivan Suzdal (isuzdal) on 2016-05-18
Changed in fuel:
assignee: Ivan Suzdal (isuzdal) → Alexander Noskov (anoskov)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers