hiera.pp task were executed before rsync task

[Vladimir Khlyunev]

ISO 9.0-275
Steps to reproduce:
            1. Create new environment
            2. Choose Neutron, Vlan
            3. Add 3 controllers
            4. Update nodes interfaces
            5. Provision 3 controllers
               (fuel node --node-id x,x,x --provision --env x)
            6. Start netconfig on second controller
               (fuel node --node x --end netconfig --env x)
Result:
https://product-ci.infra.mirantis.net/job/9.0.acceptance.ubuntu.cli_acceptance_deployment_tests/3/artifact/logs/fail_error_cli_deploy_tasks-fuel-snapshot-2016-05-03_02-48-48.tar.xz.filtered.log

Snapshot:
https://product-ci.infra.mirantis.net/job/9.0.acceptance.ubuntu.cli_acceptance_deployment_tests/3/artifact/logs/fail_error_cli_deploy_tasks-fuel-snapshot-2016-05-03_02-48-48.tar.xz

[Matthew Mosesohn (raytrac3r)]

This deployment schema does not work any more. You can only do deploy-changes with task-based deployment. This is a fuelclient issue that permits the user to run this

[Dmitry Pyzhov (dpyzhov)]

Medium priority bugs are not to be backported

[Alex Schultz (alex-schultz)]

So this is a regression from the moving of the puppet sync task from nailgun to library in combination with task based deployment. The ordering is no longer ensured correctly. I've been able to reproduce this issue more clearly by creating a plugin to be deployed prior to controllers (with min controller = 0). You can see Bug 1580295 for more details but this should be a high bug because deployments can completely fail in specific cases due to the ordering of the hiera tasks not properly being defined.

[Alex Schultz (alex-schultz)]

It should be noted that the hiera task should never be before the rsync_core_puppet task because the rsync_core_puppet task is in the pre_deployment_start/end phase. But hiera should depend on deploy_start.

[Kyrylo Galanov (kgalanov)]

It can be seen that deployment stages (like pre_deployment_*) are absolutely absent in deployment graph in case of limited deployment steps.

It is definitely not a library bug.

[Kyrylo Galanov (kgalanov)]

Why the bug happens?

Since hiera depends on a deployment stage [deploy_start]:
- id: hiera
  type: puppet
  version: 2.1.0
  groups: [primary-controller, controller, cinder, cinder-block-device,
    cinder-vmware, compute, ceph-osd, primary-mongo, mongo, virt, ironic]
  requires: [deploy_start]

These stages are stripped during limited tasks deployment when --end TASK or --start TASK parameters are given. As a result, hiera task has no upstream dependecies and is logically executed first.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/317899

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/317899
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=e23591ceb234a2311ea109d9aee8d269849a18ff
Submitter: Jenkins
Branch: master

commit e23591ceb234a2311ea109d9aee8d269849a18ff
Author: Georgy Kibardin <email address hidden>
Date: Wed May 18 11:22:36 2016 +0300

    Hiera task now depends on puppet rsync

    As with other puppet tasks it must depend on puppet modules rsync task.

    Change-Id: I7d20ea0b8bef4ee257f44579426cdfafea9c8b8d
    Closes-Bug: #1578658

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/318486

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/318486
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=e54949207aca2cf3434778fcf9845af10cab4b53
Submitter: Jenkins
Branch: stable/mitaka

commit e54949207aca2cf3434778fcf9845af10cab4b53
Author: Georgy Kibardin <email address hidden>
Date: Wed May 18 11:22:36 2016 +0300

    Hiera task now depends on puppet rsync

    As with other puppet tasks it must depend on puppet modules rsync task.

    Change-Id: I7d20ea0b8bef4ee257f44579426cdfafea9c8b8d
    Closes-Bug: #1578658
    (cherry picked from commit e23591ceb234a2311ea109d9aee8d269849a18ff)