mount point for 1Gb huge pages is created when they are disabled

Bug #1578623 reported by Sergey Kolekonov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Sergey Kolekonov
Mitaka
Fix Released
High
Sergey Kolekonov
Newton
Fix Committed
High
Sergey Kolekonov

Bug Description

Steps to reproduce:
Deploy MOS 9.0 environment with 2M hugepages enabled and disabled 1Gb hugepages
Expected results:
There's no mount point in /etc/fstab for 1Gb hugepages as they are disabled
Actual result:
From /etc/fstab:
hugetlbfs-kvm /mnt/hugepages_1GB hugetlbfs mode=775,gid=kvm,pagesize=1GB 0 0

The reason is that $hugepages_1g_opts_ensure variable is unset in this case.
It makes file_line for this mount point behave as if $hugepages_1g_opts_ensure was set to 'present'

Changed in fuel:
assignee: nobody → Sergey Kolekonov (skolekonov)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/312937

Changed in fuel:
status: New → In Progress
Changed in fuel:
importance: Undecided → High
milestone: none → 9.0
tags: added: feature-huge-pages
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/312937
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=c7e6902d5be53c125cd69597cea46454efba7260
Submitter: Jenkins
Branch: master

commit c7e6902d5be53c125cd69597cea46454efba7260
Author: Sergey Kolekonov <email address hidden>
Date: Thu May 5 16:08:58 2016 +0300

    Fix huge pages related opts behavior

    Make sure that $hugepages_1g_opts_ensure is always set as a case is possible
    when this variable is not set, file_line will treate it as 'present'

    Change-Id: I1b89195564ee41e8b04833bdb131d7e3a7f7f089
    Closes-bug: #1578623

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/315606

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (stable/mitaka)

Reviewed: https://review.openstack.org/315606
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=6731d9dc55a7565f50131dc7eb0a7b37e373b81f
Submitter: Jenkins
Branch: stable/mitaka

commit 6731d9dc55a7565f50131dc7eb0a7b37e373b81f
Author: Sergey Kolekonov <email address hidden>
Date: Thu May 5 16:08:58 2016 +0300

    Fix huge pages related opts behavior

    Make sure that $hugepages_1g_opts_ensure is always set as a case is possible
    when this variable is not set, file_line will treate it as 'present'

    Change-Id: I1b89195564ee41e8b04833bdb131d7e3a7f7f089
    Closes-bug: #1578623
    (cherry picked from commit c7e6902d5be53c125cd69597cea46454efba7260)

tags: added: on-verification
Revision history for this message
Kristina Berezovskaia (kkuznetsova) wrote :

verify on
cat /etc/fuel_build_id:
 486
cat /etc/fuel_build_number:
 486
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-release-9.0.0-1.mos6349.noarch
 fuel-misc-9.0.0-1.mos8458.noarch
 python-packetary-9.0.0-1.mos140.noarch
 fuel-bootstrap-cli-9.0.0-1.mos285.noarch
 fuel-migrate-9.0.0-1.mos8458.noarch
 rubygem-astute-9.0.0-1.mos750.noarch
 fuel-mirror-9.0.0-1.mos140.noarch
 shotgun-9.0.0-1.mos90.noarch
 fuel-openstack-metadata-9.0.0-1.mos8742.noarch
 fuel-notify-9.0.0-1.mos8458.noarch
 nailgun-mcagents-9.0.0-1.mos750.noarch
 python-fuelclient-9.0.0-1.mos325.noarch
 fuel-9.0.0-1.mos6349.noarch
 fuel-utils-9.0.0-1.mos8458.noarch
 fuel-setup-9.0.0-1.mos6349.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8742.noarch
 fuel-library9.0-9.0.0-1.mos8458.noarch
 network-checker-9.0.0-1.mos74.x86_64
 fuel-agent-9.0.0-1.mos285.noarch
 fuel-ui-9.0.0-1.mos2717.noarch
 fuel-ostf-9.0.0-1.mos936.noarch
 fuelmenu-9.0.0-1.mos274.noarch
 fuel-nailgun-9.0.0-1.mos8742.noarch

neutron+vlan, 1 controller, 1 compute with 2M pages
Check /etc/fstab. Reboot node and one more time check /etc/fstab

tags: removed: on-verification
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.