404 message after a node is removed by Fuel CLI

[Alexander Rubtsov]

--- Environment ---
[root@fuel ~]# cat /etc/fuel/version.yaml
VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "7.0"
  openstack_version: "2015.1.0-7.0"
  api: "1.0"
  build_number: "301"
  build_id: "301"
  nailgun_sha: "4162b0c15adb425b37608c787944d1983f543aa8"
  python-fuelclient_sha: "486bde57cda1badb68f915f66c61b544108606f3"
  fuel-agent_sha: "50e90af6e3d560e9085ff71d2950cfbcca91af67"
  fuel-nailgun-agent_sha: "d7027952870a35db8dc52f185bb1158cdd3d1ebd"
  astute_sha: "6c5b73f93e24cc781c809db9159927655ced5012"
  fuel-library_sha: "5d50055aeca1dd0dc53b43825dc4c8f7780be9dd"
  fuel-ostf_sha: "2cd967dccd66cfc3a0abd6af9f31e5b4d150a11c"
  fuelmain_sha: "a65d453215edb0284a2e4761be7a156bb5627677"

 --- Description ---
After a node is removed from an OpenStack environment by Fuel CLI, there is a misleading error appears:
404 Client Error: Not Found (Node not found)

This error doesn't affect the deletion process - the node is removed correctly
However, this message is confusing for customers and they doubt that the process has finished successfully

Could this error be suppressed?

 --- Steps to reproduce ---
1) Deploy an OpenStack environment (1 Controller node, 2 Compute nodes)

2) Mark one of the Compute nodes as removed using Fuel CLI:
# fuel --env 1 node remove --node 5

3) Apply the changes using Fuel CLI
# fuel --debug --env 1 deploy-changes

 --- Expected behavior ---
The node (ID=5 in our example) is no more longer belong to the environment (ID=1 in our example)
A confirmation message has appeared

 --- Actual behavior ---
The node (ID=5 in our example) is no more longer belong to the environment (ID=1 in our example)
The following message has appeared: "404 Client Error: Not Found (Node not found)"

 --- Impact ---
There is no impact on the deletion process itself
It's a user experience issue

[Alexander Rubtsov (arubtsov)]

Please nominate it for 7.0-updates as well
I don't have appropriate permissions

[Anton Matveev (amatveev)]

sla2 for 7.0 updates

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/337702

[Mikhail Zhnichkov (mzhnichkov)]

For 9.1 fix committed with bug #1565026

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/338260

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/337702
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=ba4e35a72a216207622b8e24eb610549f0755c35
Submitter: Jenkins
Branch: stable/7.0

commit ba4e35a72a216207622b8e24eb610549f0755c35
Author: Mikhail <email address hidden>
Date: Tue Jul 5 17:37:36 2016 +0300

    Fix fuel cli output function

    This patch removes printing deployment progress function
    and shows message such as fuel2.

    Change-Id: Ia116df52e431e74fda9505147f90561e46283d85
    Closes-Bug: #1576682

[Dmitry Kalashnik (dkalashnik)]

Verified on 7.0 with manually installed python-fuelclient version:

commit b005e6492ee4e7b95dc7c477571bd982e79420f4
Merge: fcc8b2d ba4e35a
Author: Jenkins <email address hidden>
Date: Tue Jul 12 09:09:08 2016 +0000

    Merge "Fix fuel cli output function" into stable/7.0

[Tatyana Kuterina (tkuterina)]

Failed on 9.1 snapshot #64

[root@nailgun ~]# shotgun2 short-report
cat /etc/fuel_build_id:
 495
cat /etc/fuel_build_number:
 495
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0

Related bug #1565026 won't fix in Mitaka

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/338260
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=783dd55bdce97de9cb107c45362ac5ad19ce0d1e
Submitter: Jenkins
Branch: stable/8.0

commit 783dd55bdce97de9cb107c45362ac5ad19ce0d1e
Author: Mikhail <email address hidden>
Date: Tue Jul 5 17:37:36 2016 +0300

    Fix fuel cli output function

    This patch removes printing deployment progress function
    and shows message such as fuel2.

    Change-Id: Ia116df52e431e74fda9505147f90561e46283d85
    Closes-Bug: #1576682

[TatyanaGladysheva (tgladysheva)]

Verified on MOS 8.0 + MU3 updates.

Before updates "404 Client Error: Not Found (Node not found)" has appeared.

After updates confirmation message has appeared:
[root@nailgun ~]# fuel --env 1 node remove --node 2
Nodes with ids [2] were removed from environment with id 1.

[root@nailgun ~]# fuel --debug --env 1 deploy-changes
PUT http://10.109.0.2:8000/api/v1/clusters/1/changes data={}
GET http://10.109.0.2:8000/api/v1/nodes/?cluster_id=1
GET http://10.109.0.2:8000/api/v1/tasks/49/
Deployment task with id 49 for the environment 1 has been started.
[root@nailgun ~]#