Warning: Scope(Class[Rabbitmq]): $ssl_stomp_port requires that $ssl => true and will be ignored

[Anastasia Palkina]

ISO #245

Steps to reproduce:
1. Install ISO
2. Open /var/log/puppet/bootstrap_admin_node.log
3. There is warning here:
Scope(Class[Rabbitmq]): $ssl_stomp_port requires that $ssl => true and will be ignored

Expected result: there is no warning in this log

[Michael Polenchuk (mpolenchuk)]

This could be fixed in rabbitmq module only,
there is no way to turn off warning unless modify the following code:
(rabbitmq/manifests/init.pp)

  if ! is_integer($ssl_stomp_port) {
    validate_re($ssl_stomp_port, '\d+')
  }
  ...........

  if $config_stomp and $ssl_stomp_port and ! $ssl {
    warning('$ssl_stomp_port requires that $ssl => true and will be ignored')
  }

[Stanislaw Bogatkin (sbogatkin)]

I did a smallest possible pull-request [0] to upstream which will allow set ssl_stomp_port to False and thus suppress the warning. If it will be passed to main branch, we can create fix for this bug easily then.

[0] https://github.com/puppetlabs/puppetlabs-rabbitmq/pull/465

[Bogdan Dobrelya (bogdando)]

Why do you want to fix
  if $config_stomp and $ssl_stomp_port and ! $ssl {
    warning('$ssl_stomp_port requires that $ssl => true and will be ignored')
  }

It looks completely valid

[Matthew Mosesohn (raytrac3r)]

Let's make a fix back into fuel-library

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/318082

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/318082
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=5726e825b69be4fa817836f94c0d5601fcaaaa50
Submitter: Jenkins
Branch: master

commit 5726e825b69be4fa817836f94c0d5601fcaaaa50
Author: Maksim Malchuk <email address hidden>
Date: Wed May 18 16:22:36 2016 +0300

    pin puppetlabs-rabbitmq to 5.4.0

    Change-Id: Ic589f5b0e978a3884d80f0fbcbdafc1e62f6c843
    Closes-Bug: #1574678
    Signed-off-by: Maksim Malchuk <email address hidden>