Fuel UI - DNS hostname field needs validation

Bug #1572296 reported by Scott Machtmes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Aleksandr Ignatev

Bug Description

In the Fuel UI ( using 8.0 as a reference ), there should be some level of validation for the DNS hostname field. This is the field located under the Settings tab, then under Security section and TLS security has been checked. The field labeled as "DNS hostname for public TLS endpoints" allows any characters to be entered, including spaces.

At a minimum we should validate and disallow spaces or other special characters that are definitely not allowed as valid DNS names. The impact of this is that you are allowed to proceed with deployment and then it can fail but not until deep into the deployment.

Dmitry Klenov (dklenov)
Changed in fuel:
milestone: none → 10.0
assignee: nobody → Fuel UI Team (fuel-ui)
importance: Undecided → Medium
status: New → Confirmed
tags: added: area-ui
Changed in fuel:
assignee: Fuel UI Team (fuel-ui) → Alexander Ignatyev (aignatyev)
Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/328002

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/328002
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=8851ac90c290f947e3ce2d053b778672de136016
Submitter: Jenkins
Branch: master

commit 8851ac90c290f947e3ce2d053b778672de136016
Author: Alexander Ignatyev <email address hidden>
Date: Fri Jun 10 02:31:11 2016 +0300

    TLS endpoint DNS hostname field validation

    Added regex validation to openstack.yaml for TLS endpoint
    DNS hostname.

    Change-Id: Ife2bea906ef8b3f24ad2dfb35bfb8b0776a41ba9
    Closes-bug: #1572296

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/392122

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/392122
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=c1ceb2c811a7eb0067099c43643acf9c1db1582c
Submitter: Jenkins
Branch: stable/mitaka

commit c1ceb2c811a7eb0067099c43643acf9c1db1582c
Author: Alexander Ignatyev <email address hidden>
Date: Fri Jun 10 02:31:11 2016 +0300

    TLS endpoint DNS hostname field validation

    Added regex validation to openstack.yaml for TLS endpoint
    DNS hostname.

    Change-Id: Ife2bea906ef8b3f24ad2dfb35bfb8b0776a41ba9
    Closes-bug: #1572296
    Closes-Bug: #1634729
    (cherry picked from commit 8851ac90c290f947e3ce2d053b778672de136016)

tags: added: in-stable-mitaka
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.