Assign public network where not needed is possible by group assigment

Bug #1572027 reported by Krzysztof Szukiełojć
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Krzysztof Szukiełojć

Bug Description

Detailed bug description:
Correctly using UI there is possiblity to assign public networks to nodes which should no have this network.
We should add check for assigned networks here: https://github.com/openstack/fuel-web/blob/master/nailgun/nailgun/api/v1/validators/network.py#L834

Expected results:
Public network should not be assigned in group assigments.

Actual result:
Public network assigned everywhere.

Additional information:
https://review.openstack.org/#/c/292356/38/nailgun/nailgun/api/v1/validators/network.py@818

Dmitry Klenov (dklenov)
Changed in fuel:
status: New → Confirmed
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Krzysztof Szukiełojć (kszukielojc)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/308957

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
Krzysztof Szukiełojć (kszukielojc) wrote :

After patch for nailgun will be delivered. UI needs to add same logic for interfaces at it uses for disks. Eg Check if all nodes are able to have same networks before group configuration.

tags: added: area-ui
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/308957
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=222a18e7d2b7c303969c7885b3e632064e91f4c9
Submitter: Jenkins
Branch: master

commit 222a18e7d2b7c303969c7885b3e632064e91f4c9
Author: Krzysztof Szukiełojć <email address hidden>
Date: Thu Apr 21 14:40:11 2016 +0200

    Check for assigment public network to wrong node

    Change-Id: Iec5eababc4a1248adad5b17065f58ef4b731ef1d
    Closes-Bug: 1572027

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.