Removal of 'deploy' task does not lead to 'provision' and 'deployment' tasks deletion

Bug #1570853 reported by Julia Aranovich
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Bulat Gaifullin
Mitaka
Fix Released
High
Bulat Gaifullin

Bug Description

Removal of parent 'deploy' task should also delete child tasks: 'provision' and 'deployment'. In 10.0 master this does not work for now.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/306527

Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Bulat Gaifullin (bgaifullin)
status: Confirmed → In Progress
Dmitry Pyzhov (dpyzhov)
no longer affects: fuel/newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/306527
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=c29a1ca8f9a50ffe724920de428760c8bea87183
Submitter: Jenkins
Branch: master

commit c29a1ca8f9a50ffe724920de428760c8bea87183
Author: Bulat Gaifullin <email address hidden>
Date: Fri Apr 15 19:12:51 2016 +0300

    Fixed update cluster status on task deletion

    Also fixed deletion subtasks with when parent is deleted

    Change-Id: I53c1fdd95380602d0ee3888f3c3d2ddc0212e695
    Closes-Bug: 1570853
    Closes-Bug: 1570762

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-ui (stable/mitaka)

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/308254

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-ui (master)

Reviewed: https://review.openstack.org/306410
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=c61444c2132384c4ce3efaebcb318cf99a685f29
Submitter: Jenkins
Branch: master

commit c61444c2132384c4ce3efaebcb318cf99a685f29
Author: Julia Aranovich <email address hidden>
Date: Fri Apr 15 13:10:56 2016 +0000

    Revert "Fixes finished deployment tasks deletion"

    This reverts commit 329a2a1fca0f3f4e57719dff218ba9724904c5ac.

    Related-Bug: #1570853

    Depends-On: I53c1fdd95380602d0ee3888f3c3d2ddc0212e695

    Change-Id: Ibf8ffabd441dda763d08bd55e96ed6dd33261e94

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-ui (stable/mitaka)

Reviewed: https://review.openstack.org/308254
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=5948a37660a01f73b1a7f3eadbace702269ef6d5
Submitter: Jenkins
Branch: stable/mitaka

commit 5948a37660a01f73b1a7f3eadbace702269ef6d5
Author: Julia Aranovich <email address hidden>
Date: Fri Apr 15 13:10:56 2016 +0000

    Revert "Fixes finished deployment tasks deletion"

    This reverts commit 329a2a1fca0f3f4e57719dff218ba9724904c5ac.

    Related-Bug: #1570853

    Depends-On: I53c1fdd95380602d0ee3888f3c3d2ddc0212e695

    Change-Id: Ibf8ffabd441dda763d08bd55e96ed6dd33261e94

tags: added: in-stable-mitaka
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/308433

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/308433
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=a322c0bdef709e354131b80f5e80596430bb2ba6
Submitter: Jenkins
Branch: stable/mitaka

commit a322c0bdef709e354131b80f5e80596430bb2ba6
Author: Bulat Gaifullin <email address hidden>
Date: Fri Apr 15 19:12:51 2016 +0300

    Fixed update cluster status on task deletion

    Also fixed deletion subtasks with when parent is deleted

    Change-Id: I53c1fdd95380602d0ee3888f3c3d2ddc0212e695
    Closes-Bug: 1570853
    Closes-Bug: 1570762
    (cherry picked from commit c29a1ca8f9a50ffe724920de428760c8bea87183)

Revision history for this message
ElenaRossokhina (esolomina) wrote :
Download full text (3.6 KiB)

Verified on iso 417-mos:
deletion of deploy tasks leads deletion of its child tasks
[root@nailgun ~]# fuel2 task list
+----+---------+-------------------------+---------+--------+----------+
| id | status | name | cluster | result | progress |
+----+---------+-------------------------+---------+--------+----------+
| 1 | ready | dump | None | {} | 100 |
| 7 | ready | dump | None | {} | 100 |
| 8 | error | deploy | 1 | {} | 100 |
| 10 | error | check_before_deployment | 1 | {} | 100 |
| 11 | error | deploy | 1 | {} | 100 |
| 14 | ready | node_deletion | 1 | {} | 100 |
| 16 | error | deployment | 1 | {} | 100 |
| 17 | running | deploy | 2 | {} | 7 |
| 20 | running | provision | 2 | {} | 23 |
| 21 | running | deployment | 2 | {} | 0 |
+----+---------+-------------------------+---------+--------+----------+
[root@nailgun ~]# fuel task --delete --tid 8
Tasks with id's 8 deleted.
[root@nailgun ~]# fuel2 task list
+----+---------+---------------+---------+--------+----------+
| id | status | name | cluster | result | progress |
+----+---------+---------------+---------+--------+----------+
| 1 | ready | dump | None | {} | 100 |
| 7 | ready | dump | None | {} | 100 |
| 11 | error | deploy | 1 | {} | 100 |
| 14 | ready | node_deletion | 1 | {} | 100 |
| 16 | error | deployment | 1 | {} | 100 |
| 17 | running | deploy | 2 | {} | 28 |
| 20 | running | provision | 2 | {} | 99 |
| 21 | running | deployment | 2 | {} | 0 |
+----+---------+---------------+---------+--------+----------+
[root@nailgun ~]# fuel task --delete --tid 11
Tasks with id's 11 deleted.
[root@nailgun ~]# fuel2 task list
+----+---------+------------+---------+--------+----------+
| id | status | name | cluster | result | progress |
+----+---------+------------+---------+--------+----------+
| 1 | ready | dump | None | {} | 100 |
| 7 | ready | dump | None | {} | 100 |
| 17 | running | deploy | 2 | {} | 28 |
| 20 | running | provision | 2 | {} | 99 |
| 21 | running | deployment | 2 | {} | 0 |
+----+---------+------------+---------+--------+----------+

cat /etc/fuel_build_id:
 417
cat /etc/fuel_build_number:
 417
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-release-9.0.0-1.mos6347.noarch
 fuel-bootstrap-cli-9.0.0-1.mos284.noarch
 fuel-migrate-9.0.0-1.mos8398.noarch
 fuel-mirror-9.0.0-1.mos137.noarch
 fuel-notify-9.0.0-1.mos8398.noarch
 nailgun-mcagents-9.0.0-1.mos746.noarch
 python-fuelclient-9.0.0-1.mos316.noarch
 fuelmenu-9.0.0-1.mos270.noarch
 fuel-9.0.0-1.mos6347.noarch
 fuel-util...

Read more...

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.