Fuel master installation in progress, but slaves VM's started

[Maksim Malchuk]

Detailed bug description:
Fuel VirtualBox scripts sometimes run slave VM's when the Fuel master node installation still in progress.

Steps to reproduce:
Execute standard launch.sh scripts.

Expected results:
Fuel slave VM's started only after successful Fuel master node installation and when the bootstrap built.

Actual result:
Fuel slave VM's started while Fuel master node installation in progress.

Reproducibility:
It is hard to reproduce this issue, but sometimes this happens on the slow environments.

Workaround:
Wait when Fuel master installation finished and reboot all the slave VMs.

Impact:
Need to reboot nodes manually.

Description of the environment:
Standard Linux/MacOSX/Windows environment.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/304832

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/304832
Committed: https://git.openstack.org/cgit/openstack/fuel-virtualbox/commit/?id=7dd1a24416cc6072156b1bcbcb41c27916f7a508
Submitter: Jenkins
Branch: master

commit 7dd1a24416cc6072156b1bcbcb41c27916f7a508
Author: Maksim Malchuk <email address hidden>
Date: Tue Apr 12 22:22:25 2016 +0300

    Ignore SSH errors

    This commit adds the new parameter to the wait_for_exec_in_bootstrap
    function for always return success when this parameter non-empty.
    This functionality will be used in the last step of the installation
    when we need to wait when Fuel master node installation ends.

    Change-Id: I399000821a4a9aeed4d359da8d0e723ea1642c88
    Closes-Bug: #1569537
    Signed-off-by: Maksim Malchuk <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/305708

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/305708
Committed: https://git.openstack.org/cgit/openstack/fuel-virtualbox/commit/?id=afd03be44cb5104f17613cf14a74d7a611d0ec87
Submitter: Jenkins
Branch: stable/mitaka

commit afd03be44cb5104f17613cf14a74d7a611d0ec87
Author: Maksim Malchuk <email address hidden>
Date: Tue Apr 12 22:22:25 2016 +0300

    Ignore SSH errors

    This commit adds the new parameter to the wait_for_exec_in_bootstrap
    function for always return success when this parameter non-empty.
    This functionality will be used in the last step of the installation
    when we need to wait when Fuel master node installation ends.

    Change-Id: I399000821a4a9aeed4d359da8d0e723ea1642c88
    Closes-Bug: #1569537
    Signed-off-by: Maksim Malchuk <email address hidden>
    (cherry picked from commit 7dd1a24416cc6072156b1bcbcb41c27916f7a508)

[TatyanaGladysheva (tgladysheva)]

Verified on vbox scripts ('stable/mitaka' branch):
[root@fuel ~]# shotgun2 short-report
cat /etc/fuel_build_id:
 482
cat /etc/fuel_build_number:
 482
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0

Actual result:
Fuel slave VM's started only after successful Fuel master node installation.