openstack glance_api_servers calc is wierd

[Andrew Woodward]

The calculation for the glance endpoint seems werd and over done

https://github.com/openstack/fuel-library/blob/master/deployment/puppet/openstack_tasks/manifests/openstack_controller/openstack_controller.pp#L54-L61

we should not need

  if $glance_ssl {
    $glance_api_servers = "${glance_protocol}://${glance_endpoint}:9292"
  } else {
    $glance_api_servers = hiera('glance_api_servers', "${management_vip}:9292")
  }

if the enpoints are looked up using the get_ssl_property properly.

Someone needs to go look at this and see what is needed to not need the extra if block

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/304551

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/304551
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=2e1ed9749d65ab9ec099f3e01a445569a075613c
Submitter: Jenkins
Branch: master

commit 2e1ed9749d65ab9ec099f3e01a445569a075613c
Author: Michael Polenchuk <email address hidden>
Date: Tue Apr 12 14:48:21 2016 +0300

    Smooth out glance api servers getter

    * get glance api servers list from one entry point for http(s)
    * set the following descending priority for getter:
      - hiera glance_api_servers raw list
      - get_ssl_property() return
      - hiera glance_endpoint ip address
      - $management_vip

    Change-Id: I80c45d1c6cdabfd8aa239ae61d8c4add5e9e8cbe
    Closes-Bug: #1568088
    Closes-bug: #1569443

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/307641

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/307641
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=7fa6ca3f131ac210742458aa4d92ddd8a2780ea1
Submitter: Jenkins
Branch: stable/mitaka

commit 7fa6ca3f131ac210742458aa4d92ddd8a2780ea1
Author: Michael Polenchuk <email address hidden>
Date: Tue Apr 12 14:48:21 2016 +0300

    Smooth out glance api servers getter

    * get glance api servers list from one entry point for http(s)
    * set the following descending priority for getter:
      - hiera glance_api_servers raw list
      - get_ssl_property() return
      - hiera glance_endpoint ip address
      - $management_vip

    Change-Id: I80c45d1c6cdabfd8aa239ae61d8c4add5e9e8cbe
    Closes-Bug: #1568088
    Closes-bug: #1569443
    (cherry picked from commit 2e1ed9749d65ab9ec099f3e01a445569a075613c)