Fuel for OpenStack

Get rid of parsing yaml in test_attributes_validation.py

Bug #1567548 reported by Arthur Svechnikov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Larry Rensing
Fuel for OpenStack 10.0

Bug Description

Steps to reproduce:
 Take a look at https://github.com/openstack/fuel-web/blob/ee15664ba0ed8a9220844c530ca163a7e40dfad4/nailgun/nailgun/test/unit/test_attributes_validator.py and understand that there are plenty of strings that are parsed by YAML

Expected result:
 Dictionaries are used

Actual result:
 Strings are used

Reproducibility:
 Always

Workaround:
 Don't open this file

Impact:
 Redundant YAML parsing

Arthur Svechnikov (asvechnikov)
Changed in fuel:
milestone: none → 10.0
assignee: nobody → Fuel Python Team (fuel-python)
tags: added: low-hanging-fruit tech-debt
Oleksiy Molchanov (omolchanov)
Changed in fuel:
importance: Undecided → Medium
status: New → Confirmed
Larry Rensing (lr699s)
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Larry Rensing (lr699s)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/304831

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/304831
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=b0ef081ab5056eb20e6adecb7848330908b6ccd6
Submitter: Jenkins
Branch: master

commit b0ef081ab5056eb20e6adecb7848330908b6ccd6
Author: Larry Rensing <email address hidden>
Date: Tue Apr 12 19:20:08 2016 +0000

    Removed unnecessary yaml parsing

    In test_attributes_validation.py, there were many strings that were
    being parsed by YAML. These strings have been converted to dicts
    to reduce redundant YAML parsing.

    Change-Id: I04e62e50f545772e54165fb2df360cef818fd3d0
    Closes-Bug: #1567548

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.