python-fuelclient needs testtools in test-requirements.txt

Bug #1564608 reported by Thomas Goirand
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Dmitry Guryanov
Mitaka
Won't Fix
Medium
Oleksiy Molchanov
Newton
Fix Committed
Medium
Dmitry Guryanov

Bug Description

testtools got removed from test-requirements.txt, even though it's still in use (a quick grep shows there's still some imports). It continues to work thanks to the ostestr requirement, but that's not a good idea to rely on just that. So I propose to re-add testtools in test-requirements until these tests using it are removed too, as it can otherwise break test listing by the test runner like testr.

Tags: area-python
Revision history for this message
Oleksiy Molchanov (omolchanov) wrote :

Thomas, what repo are we talking about?

Changed in fuel:
status: New → Incomplete
milestone: none → 9.0
Changed in fuel:
assignee: nobody → Thomas Goirand (thomas-goirand)
Revision history for this message
Roman Podoliaka (rpodolyaka) wrote :

Oleksii, it must be python-fuelclient

Changed in fuel:
assignee: Thomas Goirand (thomas-goirand) → Oleksiy Molchanov (omolchanov)
tags: added: area-python
Changed in fuel:
status: Incomplete → Confirmed
importance: Undecided → Medium
Revision history for this message
Roman Podoliaka (rpodolyaka) wrote :

No longer fixing Medium bugs in 9.0, closing as Won't Fix

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-fuelclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/320334

Changed in fuel:
assignee: Fuel Sustaining (fuel-sustaining-team) → Dmitry Guryanov (dguryanov)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-fuelclient (master)

Reviewed: https://review.openstack.org/320334
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=e67eec31daa4651a79121c6d5a2cf6d7aaca3dd5
Submitter: Jenkins
Branch: master

commit e67eec31daa4651a79121c6d5a2cf6d7aaca3dd5
Author: Dmitry Guryanov <email address hidden>
Date: Tue May 24 12:46:31 2016 +0300

    Add testtools to the test-requirements.txt file

    Change-Id: Icc106f7bfdc66343ab2ddbc78effed8e31933d02
    Closes-Bug: #1564608

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.