[sriov] [nailgun-agent] Device ID is hex, not digit

Bug #1561145 reported by Vladimir Eremin on 2016-03-23
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
High
Vladimir Eremin

Bug Description

In nailgun-agent, vf_device is got by regex
vf_device = lspci.scan(/VF\s+.*\s+Device\s+ID:\s+(\d+)/).last.first

however, vendor id is hex, e.g. 10ed:
VF offset: 128, stride: 2, Device ID: 10ed

Fix proposed to branch: master
Review: https://review.openstack.org/296666

Changed in fuel:
assignee: Fuel Library Team (fuel-library) → Vladimir Eremin (yottatsa)
status: New → In Progress
Changed in fuel:
importance: Undecided → High

Reviewed: https://review.openstack.org/296666
Committed: https://git.openstack.org/cgit/openstack/fuel-nailgun-agent/commit/?id=398bd2e9a2fa3d5e0d783499b29d66c96c695848
Submitter: Jenkins
Branch: master

commit 398bd2e9a2fa3d5e0d783499b29d66c96c695848
Author: Vladimir Eremin <email address hidden>
Date: Wed Mar 23 21:36:37 2016 +0300

    Fixed SR-IOV VF device ID parsing

    Device ID is hex number, not decimal \d was changed to [A-Fa-f0-9]

    Change-Id: Id9eacb19a296fb1b862325354be885373f5dd85b
    Closes-Bug: #1561145

Changed in fuel:
status: In Progress → Fix Committed

Verified on iso#113

cat /etc/fuel_build_id:
 113
cat /etc/fuel_build_number:
 113
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 liberty-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-library9.0-9.0.0-1.mos8198.noarch
 fuel-agent-9.0.0-1.mos266.noarch
 nailgun-mcagents-9.0.0-1.mos730.noarch
 fuel-misc-9.0.0-1.mos8198.noarch
 python-packetary-9.0.0-1.mos128.noarch
 fuel-bootstrap-cli-9.0.0-1.mos266.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8575.noarch
 network-checker-9.0.0-1.mos72.x86_64
 fuel-mirror-9.0.0-1.mos128.noarch
 fuel-openstack-metadata-9.0.0-1.mos8575.noarch
 fuel-notify-9.0.0-1.mos8198.noarch
 fuel-setup-9.0.0-1.mos6318.noarch
 python-fuelclient-9.0.0-1.mos292.noarch
 fuelmenu-9.0.0-1.mos263.noarch
 fuel-9.0.0-1.mos6318.noarch
 fuel-utils-9.0.0-1.mos8198.noarch
 fuel-nailgun-9.0.0-1.mos8575.noarch
 fuel-ostf-9.0.0-1.mos919.noarch
 fuel-release-9.0.0-1.mos6318.noarch
 rubygem-astute-9.0.0-1.mos730.noarch
 shotgun-9.0.0-1.mos85.noarch
 fuel-ui-9.0.0-1.mos2613.noarch
 fuel-migrate-9.0.0-1.mos8198.noarch

root@node-8:~# grep ^supported_pci_vendor_devs /etc/neutron/ -r
/etc/neutron/plugins/ml2/ml2_conf_sriov.ini:supported_pci_vendor_devs = 8086:10ed

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers