create_cluster returnes 500 Error on incorrect release name

[Vasyl Saienko]

PKG-systes-ubuntu job failed on cluster creation.

https://packaging-ci.infra.mirantis.net/view/MOS%209.0/job/9.0-pkg-systest-ubuntu/156

Deploy ceph HA with RadosGW for objects

        Scenario:
            1. Create cluster with Neutron
            2. Add 3 nodes with controller role
            3. Add 3 nodes with compute and ceph-osd role
            4. Deploy the cluster
            5. Check ceph status
            6. Run OSTF tests
            7. Check the radosgw daemon is started

        Duration 90m
        Snapshot ceph_rados_gw

Error from the job:

2016-03-22 22:43:24,251 - INFO fuel_web_client.py:433 -- Release_id of mitaka is None
2016-03-22 22:43:24,256 - INFO nailgun_client.py:248 -- Before post to nailgun
2016-03-22 22:43:24,274 - ERROR http.py:105 -- Internal Server Error code 500 [{"message": "Traceback (most recent call last):\n File \"/usr/lib/python2.7/site-packages/nailgun/api/v1/handlers/base.py\", line 170, in checked_data\n valid_data = method(data, **kwargs)\n File \"/usr/lib/python2.7/site-packages/nailgun/api/v1/validators/cluster.py\", line 130, in validate\n d = cls._validate_common(data)\n File \"/usr/lib/python2.7/site-packages/nailgun/api/v1/validators/cluster.py\", line 47, in _validate_common\n release = objects.Release.get_by_uid(release_id)\n File \"/usr/lib/python2.7/site-packages/nailgun/objects/base.py\", line 59, in get_by_uid\n res = q.get(uid)\n File \"/usr/lib64/python2.7/site-packages/sqlalchemy/orm/query.py\", line 831, in get\n return self._get_impl(ident, loading.load_on_ident)\n File \"/usr/lib64/python2.7/site-packages/sqlalchemy/orm/query.py\", line 864, in _get_impl\n return fallback_fn(self, key)\n File \"/usr/lib64/python2.7/site-packages/sqlalchemy/orm/loading.py\", line 219, in load_on_ident\n return q.one()\n File \"/usr/lib64/python2.7/site-packages/sqlalchemy/orm/query.py\", line 2693, in one\n ret = list(self)\n File \"/usr/lib64/python2.7/site-packages/sqlalchemy/orm/query.py\", line 2736, in __iter__\n return self._execute_and_instances(context)\n File \"/usr/lib64/python2.7/site-packages/sqlalchemy/orm/query.py\", line 2751, in _execute_and_instances\n result = conn.execute(querycontext.statement, self._params)\n File \"/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py\", line 914, in execute\n return meth(self, multiparams, params)\n File \"/usr/lib64/python2.7/site-packages/sqlalchemy/sql/elements.py\", line 323, in _execute_on_connection\n return connection._execute_clauseelement(self, multiparams, params)\n File \"/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py\", line 1010, in _execute_clauseelement\n compiled_sql, distilled_params\n File \"/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py\", line 1146, in _execute_context\n context)\n File \"/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py\", line 1341, in _handle_dbapi_exception\n exc_info\n File \"/usr/lib64/python2.7/site-packages/sqlalchemy/util/compat.py\", line 200, in raise_from_cause\n reraise(type(exception), exception, tb=exc_tb, cause=cause)\n File \"/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py\", line 1139, in _execute_context\n context)\n File \"/usr/lib64/python2.7/site-packages/sqlalchemy/engine/default.py\", line 450, in do_execute\n cursor.execute(statement, parameters)\nDataError: (psycopg2.DataError) invalid input syntax for integer: \"None\"\nLINE 3: WHERE releases.id = 'None'\n ^\n [SQL: 'SELECT releases.id AS releases_id, releases.name AS releases_name, releases.version AS releases_version, releases.description AS releases_description, releases.operating_system AS releases_operating_system, releases.state AS releases_state, releases.networks_metadata AS releases_networks_metadata, releases.attributes_metadata AS releases_attributes_metadata, releases.volumes_metadata AS releases_volumes_metadata, releases.modes_metadata AS releases_modes_metadata, releases.roles_metadata AS releases_roles_metadata, releases.network_roles_metadata AS releases_network_roles_metadata, releases.vmware_attributes_metadata AS releases_vmware_attributes_metadata, releases.components_metadata AS releases_components_metadata, releases.modes AS releases_modes, releases.extensions AS releases_extensions, releases.node_attributes AS releases_node_attributes \\nFROM releases \\nWHERE releases.id = %(param_1)s'] [parameters: {'param_1': u'None'}]\n", "errors": []}]
2016-03-22 22:43:24,275 - ERROR __init__.py:66 -- create_cluster raised: HTTPError()
Traceback: Traceback (most recent call last):
  File "/home/jenkins/workspace/9.0-pkg-systest-ubuntu/fuel-qa/fuelweb_test/__init__.py", line 59, in wrapped
    result = func(*args, **kwargs)
  File "/home/jenkins/workspace/9.0-pkg-systest-ubuntu/fuel-qa/fuelweb_test/helpers/decorators.py", line 146, in wrapped
    response = func(*args, **kwargs)
  File "/home/jenkins/workspace/9.0-pkg-systest-ubuntu/fuel-qa/fuelweb_test/models/nailgun_client.py", line 251, in create_cluster
    data=data)
  File "/home/jenkins/workspace/9.0-pkg-systest-ubuntu/fuel-qa/fuelweb_test/helpers/http.py", line 75, in post
    return self._open(req)
  File "/home/jenkins/workspace/9.0-pkg-systest-ubuntu/fuel-qa/fuelweb_test/helpers/http.py", line 92, in _open
    return self._get_response(req)
  File "/home/jenkins/workspace/9.0-pkg-systest-ubuntu/fuel-qa/fuelweb_test/helpers/http.py", line 116, in _get_response
    return self.opener.open(req)
  File "/usr/lib/python2.7/urllib2.py", line 410, in open
    response = meth(req, response)
  File "/usr/lib/python2.7/urllib2.py", line 523, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python2.7/urllib2.py", line 448, in error
    return self._call_chain(*args)
  File "/usr/lib/python2.7/urllib2.py", line 382, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 531, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
HTTPError: HTTP Error 500: Internal Server Error

[Dmitry Pyzhov (dpyzhov)]

The root cause is misconfigured CI job, see bug #1560905. However nailgun shouldn't throw error 500 for incorrect params. Setting medium priority for nailgun part.

[Bug Checker Bot (bug-checker)]

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

actual result

expected result

steps to reproduce

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/303281

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/303281
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=2d40272639da63acf6a2d889d9de0b17c7ebc521
Submitter: Jenkins
Branch: master

commit 2d40272639da63acf6a2d889d9de0b17c7ebc521
Author: Georgy Kibardin <email address hidden>
Date: Fri Apr 8 11:26:39 2016 +0300

    Invalid release id format validation

    Explicitly validate release id data type to avoid 500 response.

    Change-Id: I87a6cc6ae4d0a2e157e1c3ab41b18e06ca6c971b
    Closes-Bug: #1560846