Hot-pluggable plugins: deployment failed on boot_time calculation

[Vladimir Khlyunev]

Several swarm tests failed:
https://product-ci.infra.mirantis.net/job/9.0.system_test.ubuntu.plugins.fuel_plugin_example/53/testReport/(root)/five_ctrl_enable_installed_after_deploy_add/five_ctrl_enable_installed_after_deploy_add/
https://product-ci.infra.mirantis.net/job/9.0.system_test.ubuntu.plugins.fuel_plugin_example/53/testReport/(root)/three_ctrl_enable_installed_after_deploy_redeploy/three_ctrl_enable_installed_after_deploy_redeploy/
https://product-ci.infra.mirantis.net/job/9.0.system_test.ubuntu.plugins.fuel_plugin_example/53/testReport/(root)/three_ctrl_install_enable_after_create/three_ctrl_install_enable_after_create/

ISO 9.0-90
Snapshot https://product-ci.infra.mirantis.net/job/9.0.system_test.ubuntu.plugins.fuel_plugin_example/53/artifact/logs/fail_error_three_ctrl_install_after_create-fuel-snapshot-2016-03-21_01-24-25.tar.xz

Steps:
- Create cluster with any settings
- Install&activate example_v4 plugin
- Add some nodes
- Deploy

Result:
Task 'deploy' has incorrect status. error != ready, 'Deployment has failed. Method task_deploy. Task[_plugin_pre_deployment_hook#6/2]: Invalid task status! (#<ConditionVariable:0x00000002f8fe38>).

astute.log contains the same uninformative message and I didn't find any errors on nodes in puppet.log

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/295396

[Matthew Mosesohn (raytrac3r)]

My mistake. This review isn't for that bug.

[Bug Checker Bot (bug-checker)]

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

actual result

expected result

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/299424

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/299424
Committed: https://git.openstack.org/cgit/openstack/fuel-astute/commit/?id=cbd121f2188ddb6fe8ccd643d35d3bc86afddedc
Submitter: Jenkins
Branch: master

commit cbd121f2188ddb6fe8ccd643d35d3bc86afddedc
Author: Alexander Kislitsky <email address hidden>
Date: Wed Mar 30 12:50:40 2016 +0300

    Failures of reboot task fixed

    Checking of MClient results fixed in
    astute.task.run_shell_without_check. In case of empty
    array of results we had "undefined method 'results'
    for nil:NilClass".

    Function boot_time returns 0 in case of error, thus
    status_calculation for reboot taks is fixed to use proper
    conditions for status calculation.

    Parameter node_uid passed to run_shell_without_check
    shouldn't be an Array.

    Change-Id: Ic9311ae4129ad2a788289a1066c344b3aa437bb8
    Closes-Bug: #1560021

[Aleksei Stepanov (penguinolog)]

Now it's fails with:
err: (/Firewall[007 tinyproxy]) Could not evaluate: undefined method `scan' for nil:NilClass

[Vladimir Sharshov (vsharshov)]

I do not see any connection between theme of this bug and "Could not evaluate: undefined method `scan' for nil:NilClass".

We should create separate bug to find out the reason

[Aleksei Stepanov (penguinolog)]

New bug created after discussion

[Aleksei Stepanov (penguinolog)]

https://product-ci.infra.mirantis.net/view/9.0_swarm/job/9.0.system_test.ubuntu.plugins.fuel_plugin_example/90/consoleFull
Deploy successful. Another bug found.