openstack-network-server-nova started before rsync task

[Vladimir Khlyunev]

Swarm test failed:

https://product-ci.infra.mirantis.net/job/9.0.system_test.ubuntu.ha_neutron_tun_scale/53/
ISO #90
Snapshot: https://product-ci.infra.mirantis.net/job/9.0.system_test.ubuntu.ha_neutron_tun_scale/53/artifact/logs/fail_error_neutron_tun_scalability-fuel-snapshot-2016-03-20_22-49-15.tar.xz

Steps to reproduce:
1. Create cluster (TUN, no ceph)
2. Add 1 controller node
3. Deploy the cluster < Failed here

Expected result:
No errors, cluster is deployed

Actual result:
Trace:
node-3 2016-03-20T22:49:02.034628 err: Could not run: Could not find file /etc/puppet/modules/osnailyfacter/modular/openstack-network/server-nova.pp
full trace at:
https://product-ci.infra.mirantis.net/job/9.0.system_test.ubuntu.ha_neutron_tun_scale/53/artifact/logs/fail_error_neutron_tun_scalability-fuel-snapshot-2016-03-20_22-49-15.tar.xz.filtered.log

[Matthew Mosesohn (raytrac3r)]

This is an intermittent issue. I encountered it with the following scenario:
1 - install Fuel Master with 9.0 iso #71
2 - install detach-keystone and detach-database plugins
3 - deploy cluster with 1 controller and 1 database+keystone role
4 - add 1 node with cinder+compute role <- failed here

It's not every time, and redeploying the failed compute+cinder node caused rsync to run.

This issue is related to orchestration and the trask graph completely. I'm passing to fuel-python

[Bug Checker Bot (esikachev-l)]

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

actual result

expected result

steps to reproduce

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/295990

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/295990
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=23eae3a455bbf55254b62e571a6989e3d04ae0ff
Submitter: Jenkins
Branch: master

commit 23eae3a455bbf55254b62e571a6989e3d04ae0ff
Author: Vladimir Kuklin <email address hidden>
Date: Tue Mar 22 21:25:56 2016 +0300

    Fix check for cross-referring self-dependencies

    This fix fixes an issue when the code of cross-reference
    checking was too strict and checked not combination of
    "task_name", "node_id",
    but
    only "node_id" instead.
    This leads to the situation when cross-depends role: .*
    does not include the task on the same node even
    when task names of the required and of the requiring
    tasks are different.

    E.g. such dependency:

    with nodes [1,2]
    task: a
    cross-depends:
       name: b

    on node_id 1

    should have requires: (b,1), (b,2)

    but had requires: (b,2)

    due to this bug

    Change-Id: Ic8b6f86533670fe477cc68db6a0d932ee8501cc3
    Closes-bug: #1559968

[Dmitriy Kruglov (dkruglov)]

Verified on MOS 9.0, ISO build 301.
The issue is fixed.

ISO details:
cat /etc/fuel_build_id:
 301
cat /etc/fuel_build_number:
 301
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-release-9.0.0-1.mos6344.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8680.noarch
 fuel-mirror-9.0.0-1.mos133.noarch
 fuel-openstack-metadata-9.0.0-1.mos8680.noarch
 python-fuelclient-9.0.0-1.mos313.noarch
 fuel-9.0.0-1.mos6344.noarch
 fuel-nailgun-9.0.0-1.mos8680.noarch
 rubygem-astute-9.0.0-1.mos742.noarch
 fuel-library9.0-9.0.0-1.mos8337.noarch
 network-checker-9.0.0-1.mos72.x86_64
 fuel-agent-9.0.0-1.mos276.noarch
 fuel-ui-9.0.0-1.mos2676.noarch
 fuel-setup-9.0.0-1.mos6344.noarch
 nailgun-mcagents-9.0.0-1.mos742.noarch
 fuel-misc-9.0.0-1.mos8337.noarch
 python-packetary-9.0.0-1.mos133.noarch
 fuelmenu-9.0.0-1.mos269.noarch
 fuel-bootstrap-cli-9.0.0-1.mos276.noarch
 fuel-migrate-9.0.0-1.mos8337.noarch
 shotgun-9.0.0-1.mos88.noarch
 fuel-notify-9.0.0-1.mos8337.noarch
 fuel-ostf-9.0.0-1.mos933.noarch
 fuel-utils-9.0.0-1.mos8337.noarch