Network settings are not protected when environment deployment is in progress

[Sofiia Andriichenko]

There are several environment can be in production fuel. Sometimes we can break settings of another environment while it is being deployed.

Steps to reproduce:.
1. Prepare FueL environment
2. Configure network settings
3. Start deployment. Do next steps while deployment is in progress.
4. Go to tab "Networks"
5. Check that "Network Settings" blocked
6. ssh root@<IP-fuel>
7. [root@nailgun ~]# fuel network-group list
8. [root@nailgun ~]# fuel network-group --set --network <id_public> --cidr <CIDR> --gateway <Gateway>

Actual result:
Network group id=<id_public> has been updated.
Network settings do not protected.

Expected result:
"Network Settings" protected

[Sergey Vasilenko (xenolog)]

IMHO

Expected result:
* Network Settings are blocked for change while deploy process going
* Network Settings are able for change while deploy process end (it does not matter fail or successful)

[Artem Panchenko (apanchenko-8)]

Sofiia,

thank you for the report! I removed private links to iso from the description, because the bug is public. Please attach an output of `shotgun2 report` command instead, if you want to provide Fuel version information in a bug report.

[Sofiia Andriichenko (sandriichenko)]

2016-03-21 09:58:33 DEBUG 3589 (manager) Initializing snapshot manager
2016-03-21 09:58:33 DEBUG 3589 (manager) Making report
2016-03-21 09:58:33 DEBUG 3589 (manager) Gathering report for: {'command': ['cat /etc/fuel_build_id', 'cat /etc/fuel_build_number', 'cat /etc/fuel_release', 'cat /etc/fuel_openstack_version', "rpm -qa | \\\negrep 'fuel|astute|network-checker|shotgun' | \\\nwhile read package; do\n echo\n echo $package\n rpm -q --changelog $package | head -2\ndone\n"], 'host': {}, 'type': 'command'}
2016-03-21 09:58:33 DEBUG 3589 (driver) Initializing driver Command: host={}
2016-03-21 09:58:33 DEBUG 3589 (driver) Running local command: cat /etc/fuel_build_id
2016-03-21 09:58:33 DEBUG 3589 (utils) Trying to execute command: cat /etc/fuel_build_id
2016-03-21 09:58:33 DEBUG 3589 (driver) Running local command: cat /etc/fuel_build_number
2016-03-21 09:58:33 DEBUG 3589 (utils) Trying to execute command: cat /etc/fuel_build_number
2016-03-21 09:58:33 DEBUG 3589 (driver) Running local command: cat /etc/fuel_release
2016-03-21 09:58:33 DEBUG 3589 (utils) Trying to execute command: cat /etc/fuel_release
2016-03-21 09:58:33 DEBUG 3589 (driver) Running local command: cat /etc/fuel_openstack_version
2016-03-21 09:58:33 DEBUG 3589 (utils) Trying to execute command: cat /etc/fuel_openstack_version
2016-03-21 09:58:33 DEBUG 3589 (driver) Running local command: rpm -qa | \
egrep 'fuel|astute|network-checker|shotgun' | \
while read package; do
  echo
  echo $package
  rpm -q --changelog $package | head -2
done

2016-03-21 09:58:33 DEBUG 3589 (utils) Trying to execute command: rpm -qa | \
egrep 'fuel|astute|network-checker|shotgun' | \
while read package; do
  echo
  echo $package
  rpm -q --changelog $package | head -2
done

+---------------------------+-------------------------------------------------+--------------------------------------------------------------------------------+
| Host | Reporter | Report |
+---------------------------+-------------------------------------------------+--------------------------------------------------------------------------------+
| nailgun.test.domain.local | cat /etc/fuel_build_id | 68 |
| | | |
| nailgun.test.domain.local | cat /etc/fuel_build_number | 68 |
| | | |
| nailgun.test.domain.local | cat /etc/fuel_release | 9.0 |
| | | |
| n...

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/308017

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/308017
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=6ba4c90f41dd23eea99ef055e1950f25e011b4b2
Submitter: Jenkins
Branch: master

commit 6ba4c90f41dd23eea99ef055e1950f25e011b4b2
Author: slava <email address hidden>
Date: Tue Apr 19 22:51:10 2016 +0300

    Do not allow to update network group when deploy is in progress

    Change-Id: Ia49e2524613171e14d69d8038db439f1f87bdf13
    Closes-Bug: #1559170