Error: p_neutron-l3-agent is not a valid resource while banning neutron

[Alexandr Kostrikov]

Detailed bug description:
At swarm job [0] there were a failure on scenario:
Check l3-agent rescheduling after l3-agent dies on vxlan

        Scenario:
            1. Revert snapshot with neutron cluster
            2. Create an instance with a key pair
            3. Manually reschedule router from primary controller
               to another one
            4. Stop l3-agent on new node with pcs
            5. Check l3-agent was rescheduled
            6. Check network connectivity from instance via
               dhcp namespace
            7. Run OSTF

        Duration 30m

The error was 'l3 agent wasn't banned, it is still node-6.test.domain.local'

Command to ban resource had failed:
root@node-1:~# pcs resource ban p_neutron-l3-agent node-6.test.domain.local
Error: p_neutron-l3-agent is not a valid resource

The `pcs status` on node-6 is at [1]

Library team, please provide correct command to ban neutron resource in comments and reassign it to Fuel-qa team.

Also, fuel-qa should check return code of pcs commands.

[0] https://product-ci.infra.mirantis.net/job/9.0.system_test.ubuntu.ha_neutron_destructive_vxlan/48/testReport/(root)/neutron_l3_migration_vxlan/
[1] http://paste.openstack.org/show/490744/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/296866

[Kyrylo Galanov (kgalanov)]

Hi QA team,

Resource names were changed: p_ prefix was removed.
You need to update the tests.
If you look at pacemaker/lib/puppet/provider/service/pacemaker.rb you can see how you can do it the best way.
1. Get all resources list
2. Find a resource by mask /(?:p_)neutron-l3-agent/
3. Execute a command with correct resource name.
4. Make the code reusable for all similar cases

---
 Clone Set: clone_neutron-openvswitch-agent [neutron-openvswitch-agent]
 Clone Set: clone_neutron-l3-agent [neutron-l3-agent]
 Clone Set: clone_neutron-metadata-agent [neutron-metadata-agent]
 Clone Set: clone_neutron-dhcp-agent [neutron-dhcp-agent]

[OpenStack Infra (hudson-openstack)]

Change abandoned by Kyrylo Galanov (<email address hidden>) on branch: master
Review: https://review.openstack.org/296866

[Bug Checker Bot (bug-checker)]

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

actual result

version

expected result

steps to reproduce

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

[Matthew Mosesohn (raytrac3r)]

Nastya U, please explain why this bug was moved back without any comment.

[Nastya Urlapova (aurlapova)]

Matt, there is a question in original description:
Library team, please provide correct command to ban neutron resource in comments and reassign it to Fuel-qa team.

+ attached review has -2 https://review.openstack.org/#/c/296866/
so we are still waiting suggestions from fuel-lib team.

[Matthew Mosesohn (raytrac3r)]

Nastya, this bug can only be solved by merging https://review.openstack.org/#/c/296866/ I will discuss with Sergii today on that.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/296866
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=d539686847c9102f2a7a6f326579d920dc66e932
Submitter: Jenkins
Branch: master

commit d539686847c9102f2a7a6f326579d920dc66e932
Author: Kyrylo Galanov <email address hidden>
Date: Thu Mar 24 02:46:51 2016 +0100

    Fix neutron resource name

    Change-Id: I5054f69d237640a39fd11801eefd8fd012384bbf
    Closes-bug: #1558154

[Artem Hrechanychenko (agrechanichenko)]

https://product-ci.infra.mirantis.net/job/9.0.system_test.ubuntu.ha_neutron_destructive_vxlan/79/testReport/%28root%29/neutron_l3_migration_vxlan/neutron_l3_migration_vxlan/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/306995

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/306995
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=671c511f51dfc66760f4c53742c568c6fb3b095d
Submitter: Jenkins
Branch: stable/mitaka

commit 671c511f51dfc66760f4c53742c568c6fb3b095d
Author: Kyrylo Galanov <email address hidden>
Date: Thu Mar 24 02:46:51 2016 +0100

    Fix neutron resource name

    Change-Id: I5054f69d237640a39fd11801eefd8fd012384bbf
    Closes-bug: #1558154
    (cherry picked from commit d539686847c9102f2a7a6f326579d920dc66e932)

[Tatyanka (tatyana-leontovich)]

for mitaka verified on 285 iso