Confusing spec of nailgun-agent package

Bug #1558022 reported by Dmitry Kaigarodеsev on 2016-03-16
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
High
Sergey Kulanov

Bug Description

Package nailgun-agent have confusing spec file:

- spec name is 'fuel-nailgun-agent.spec'
- package name directive is 'nailgun-agent'
- source directive 'fuel-%{name}-%{version}.tar.gz'

https://github.com/openstack/fuel-nailgun-agent/blob/master/specs/fuel-nailgun-agent.spec

Please fix naming in spec file.

Roman Vyalov (r0mikiam) wrote :

reassign to mos packaging team , because responsibility of fuel specs on packaging team

Changed in fuel:
assignee: Fuel build team (fuel-build) → MOS Packaging Team (mos-packaging)
tags: added: area-mos
removed: area-build
Changed in fuel:
assignee: MOS Packaging Team (mos-packaging) → Sergey Kulanov (skulanov)
status: New → In Progress

raise priority to Critical, since it's a blocker for job https://bugs.launchpad.net/fuel/+bug/1557524

Changed in fuel:
importance: High → Critical
Sergey Kulanov (skulanov) wrote :

@Dima, you are pointing to high bug, so this bug is also high.
Moreover all patches are ready [1], but we cannot merge them due to red BVT

[1.] https://review.openstack.org/#/q/topic:rename-nailgun-agent

Changed in fuel:
importance: Critical → High

Reviewed: https://review.openstack.org/293380
Committed: https://git.openstack.org/cgit/openstack/fuel-main/commit/?id=2874ae63a21a99fb60cbfd2e5e5b6a7480a3c6b0
Submitter: Jenkins
Branch: master

commit 2874ae63a21a99fb60cbfd2e5e5b6a7480a3c6b0
Author: Sergey Kulanov <email address hidden>
Date: Wed Mar 16 13:24:35 2016 +0200

    Align nailgun-agent rpm spec-filename to package name

    Related-bug: #1558022
    Change-Id: Ica3614f8b65f5ef8a6f6faf8cad4b86c4a61470b

Reviewed: https://review.openstack.org/293378
Committed: https://git.openstack.org/cgit/openstack/fuel-nailgun-agent/commit/?id=08625168b34c1d559f6b12c600f0cd73dd10ec03
Submitter: Jenkins
Branch: master

commit 08625168b34c1d559f6b12c600f0cd73dd10ec03
Author: Sergey Kulanov <email address hidden>
Date: Wed Mar 16 13:18:09 2016 +0200

    Align rpm spec filename to package name

    Partial-bug: #1558022

    Change-Id: I358d9599d5f2f6d9c7deca995c7992c94c4cb81d

Changed in fuel:
status: In Progress → Fix Committed
Sergey Yudin (tsipa740) wrote :

This commit break iso builder

14:22:06 + sudo chroot /home/jenkins/slave/workspace/tmp/FUEL-custom_9.0_iso/build/packages/rpm/SANDBOX/fuel-nailgun-agent rpmbuild --nodeps --define _topdir /tmp --define release 1.mos163 -ba /tmp/fuel-nailgun-agent.spec
14:22:06 error: Name field must be present in package: (main package)
14:22:06 error: Version field must be present in package: (main package)
14:22:06 error: Release field must be present in package: (main package)
14:22:06 error: Summary field must be present in package: (main package)
14:22:06 error: License field must be present in package: (main package)

fuel-main still using fuel-nailgun-agent.spec in ./packages/rpm/module.mk

Sergey Yudin (tsipa740) wrote :

Sorry, ignore my report please, we've not fetched related commit onto main.

tags: added: on-verification
Changed in fuel:
status: Fix Committed → Fix Released
tags: removed: on-verification
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers