[system-tests] Pylint should be used for internal checks

[Aleksei Stepanov]

1. add pylint config
2. add pylint to tox
3. fix trivial errors before switch checks to voting mode on CI

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/292295

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/292341

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/292342

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/292344

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/292345

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/292346

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/290390
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=cdb190f01d259772c08d83c491db018d18ffd7bc
Submitter: Jenkins
Branch: master

commit cdb190f01d259772c08d83c491db018d18ffd7bc
Author: Alexey Stepanov <email address hidden>
Date: Wed Mar 9 13:50:50 2016 +0300

    Python3 code compatibility: tox.ini checks v1

    Add pep8-py34/35 (deprecation check & etc).
    Add pylint with not ignored Python 3 incompatible warnings
    Add documents test

    Next: add full py34/35 check after modules compatibility fix

    blueprint fuel-qa-python3-compatibility
    Related-bug: #1556791

    Change-Id: I65a540aad70bde73043ed36dca222f472f8fe108

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/292847

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/292960

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/292962

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/292963

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alexey Stepanov (<email address hidden>) on branch: master
Review: https://review.openstack.org/292963
Reason: Changes joined to part 2

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/293332

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/293332
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=207f06ecf11ebe41d090ebb5232a815a3418e87b
Submitter: Jenkins
Branch: master

commit 207f06ecf11ebe41d090ebb5232a815a3418e87b
Author: Vladimir Khlyunev <email address hidden>
Date: Wed Mar 16 12:10:56 2016 +0300

    Disable OS upgrade tests

    The OS upgrade procedure was changed and actual code
    contains outdated upgrade procedure which uses tarball-based upgrade.
    We should disable this tests until new upgrade of OS will be implemented

    Change-Id: Ide45d1c03114e472c7f83871dac1ba54536575e0
    Partial-bug:1546943
    Related-bug:1556791

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/293510

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/292341
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=37009b912a99e696429e682dea0e5e19a7bbea3e
Submitter: Jenkins
Branch: master

commit 37009b912a99e696429e682dea0e5e19a7bbea3e
Author: Alexey Stepanov <email address hidden>
Date: Mon Mar 14 14:36:14 2016 +0300

    Pylint: fix trivial issues 1

    Change-Id: Ie847c0c91f4de31d19e559ab6becaf0a3934a7d0
    fix: invalid indent, incorrect formatting, incorrect type check
    Related-bug: #1556791

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/292342
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=b661d47b32aa6e5578dc1f95a0e9747dd81d6e26
Submitter: Jenkins
Branch: master

commit b661d47b32aa6e5578dc1f95a0e9747dd81d6e26
Author: Alexey Stepanov <email address hidden>
Date: Mon Mar 14 15:00:45 2016 +0300

    Pylint: fix trivial issues 2

    Change-Id: Id29cb8831714fd96960f85c29d866084a5565f5c
    fix: invalid import order, double import, relative import, no super call, instance defined outside of init, incorrect __all__ variable
    Related-bug: #1556791

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/292344
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=41d761bfdc385479c8d36add5677d5bcad819ab5
Submitter: Jenkins
Branch: master

commit 41d761bfdc385479c8d36add5677d5bcad819ab5
Author: Alexey Stepanov <email address hidden>
Date: Mon Mar 14 15:07:33 2016 +0300

    Pylint: fix trivial issues 3

    Change-Id: If141aba37568d102524242ef22bda1ab5e68f080
    fix: unused variables, cycles formed as unassigned lists
    Related-bug: #1556791

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/292345
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=e7ae1fec8e378fa7805d6f2034df14b98ea0b850
Submitter: Jenkins
Branch: master

commit e7ae1fec8e378fa7805d6f2034df14b98ea0b850
Author: Alexey Stepanov <email address hidden>
Date: Mon Mar 14 15:11:29 2016 +0300

    Pylint: fix trivial issues 4

    Change-Id: I512c6faa3870b62a1516fd7aa5f5dd0979f745c7
    fix: dangerous default values
    Related-bug: #1556791

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/292346
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=abcb0899db2f40eb5051270c72f031322f30317a
Submitter: Jenkins
Branch: master

commit abcb0899db2f40eb5051270c72f031322f30317a
Author: Alexey Stepanov <email address hidden>
Date: Mon Mar 14 15:15:35 2016 +0300

    Pylint: fix trivial issues 5

    Change-Id: Ifce0db7add536ec8be6728a573619ddef018401f
    fix: overridden builtins
    Related-bug: #1556791

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/292295
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=e07b35a2e0ab36db5f98523cd62045de826a8658
Submitter: Jenkins
Branch: master

commit e07b35a2e0ab36db5f98523cd62045de826a8658
Author: Alexey Stepanov <email address hidden>
Date: Mon Mar 14 11:31:15 2016 +0300

    Pylint: fix trivial issues 6

    fix: usage generator as list
    Related-bug: #1556791
    Closes-bug: #1556054
    Change-Id: Iff7b562e599ac1b81f6043f5ec69a6dbc4a86669

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dmitry Tyzhnenko (<email address hidden>) on branch: master
Review: https://review.openstack.org/292847
Reason: Already fixed

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/293980

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/293510
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=7ba03f6537fb990f04bb4bf93e7f5a78bb76dd6a
Submitter: Jenkins
Branch: master

commit 7ba03f6537fb990f04bb4bf93e7f5a78bb76dd6a
Author: Alexey Stepanov <email address hidden>
Date: Wed Mar 16 18:21:43 2016 +0300

    Pylint: fix trivial issues 7

    Change-Id: I65bd247fe65facfab9c88d5f6e751ceed3135558
    fix: no default value in base class
    Fix: property, which raising ValuError in base class and override in child classes
    Related-bug: #1556791

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/292960
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=235959b861ed215fd0cfc510c1788e2583496ded
Submitter: Jenkins
Branch: master

commit 235959b861ed215fd0cfc510c1788e2583496ded
Author: Alexey Stepanov <email address hidden>
Date: Tue Mar 15 13:53:13 2016 +0300

    Pylint: fix trivial issues 8

    fix: make methods static, if self is not used inside
    (call is not changed, backward change is possible without code change,
      if self will be required)
    Related-bug: #1556791

    Change-Id: I48175c0179e0fde69ed9b527ab570a267b9191a5

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/293980
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=4c6ef9699bc7e587b13d13933794f8a7e3b34a11
Submitter: Jenkins
Branch: master

commit 4c6ef9699bc7e587b13d13933794f8a7e3b34a11
Author: Alexey Stepanov <email address hidden>
Date: Thu Mar 17 14:15:50 2016 +0300

    Python3 code compatibility: filter, map, zip

    Do not use filter(), map() or zip() for not iterator tasks

    blueprint fuel-qa-python3-compatibility
    Related-bug: #1556791

    Change-Id: I6e031ed2ca18080a15eecd5d0c1db275f9ec9aa1

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/295158

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/295233

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/295158
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=ee4eaaaf10144fc01f0ea3358bf1432a16f6e46e
Submitter: Jenkins
Branch: master

commit ee4eaaaf10144fc01f0ea3358bf1432a16f6e46e
Author: Alexey Stepanov <email address hidden>
Date: Mon Mar 21 12:26:44 2016 +0300

    Pylint: fix trivial issues 9

    fix: undefined-loop-variable - at some places it's fake fail,
     at 2 places was a real problem
    Related-bug: #1556791

    Change-Id: I321d82cac0a3c031c43fd9e1bcbf9bfaab3b1164

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/295233
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=bd567ec4209a9d2b6402ee9a7048e859faa55ae4
Submitter: Jenkins
Branch: master

commit bd567ec4209a9d2b6402ee9a7048e859faa55ae4
Author: Alexey Stepanov <email address hidden>
Date: Mon Mar 21 14:38:04 2016 +0300

    Pylint: fix false negative results

    1. Disable cyclic imports scan due to false-negative result on new tests
    2. Disable no-member check on methods library and factory on new tests

    Change-Id: I00172fef100bc859d994131679c897402630fddf
    Related-bug: #1556791

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/292896
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=ed07d4aae7ea157223e50cd4d464d17438a0229f
Submitter: Jenkins
Branch: master

commit ed07d4aae7ea157223e50cd4d464d17438a0229f
Author: Alexey Stepanov <email address hidden>
Date: Tue Mar 15 15:18:54 2016 +0300

    Python3 code compatibility: division, round

    Make division transparent-compatible (from __future__ import division, // for strict int result)
    Do not use round due to different types of result objects

    blueprint fuel-qa-python3-compatibility
    Related-bug: #1556791

    Change-Id: I7bb173c6f97ac046af45c3f52cc32846a93a8981

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/292962
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=fe0dc7cacbbabc6417b67a33b94f39cc7bd7a7f6
Submitter: Jenkins
Branch: master

commit fe0dc7cacbbabc6417b67a33b94f39cc7bd7a7f6
Author: Alexey Stepanov <email address hidden>
Date: Tue Mar 15 17:40:41 2016 +0300

    Pylint: fix trivial issues 10

    Change-Id: I5cbf0cf588f8cbeefefcd1fac3ba714fb6426a40
    fix: redefined variable type
    Related-bug: #1556791

[Aleksei Stepanov (penguinolog)]

Vote has been added on gerrit.