sriov_numvfs: accepts negative int and float values

Bug #1556115 reported by Volodymyr Shypyguzov on 2016-03-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
High
slava valyavskiy

Bug Description

It's possible now to set sriov_numvfs to negative or float value

Steps to reproduce:

1. Download interfaces.yaml for node with SR-IOV support (fuel node --node-id 4 --download --network)
2. Set sriov_numvfs to negative value
3. Upload interfaces.yaml (fuel node --node-id 4 --upload --network)
4. Download interfaces.yaml for same node (fuel node --node-id 4 --download --network) and check it's content
5. Set sriov_numvfs to float value
6. Upload interfaces.yaml (fuel node --node-id 4 --upload --network)
7. Download interfaces.yaml for same node (fuel node --node-id 4 --download --network) and check it's content

Expected result: BAD request error should be raised in both cases

Actual result: sriov_numvfs is set to incorrect value

Changed in fuel:
milestone: none → 9.0
status: New → Confirmed
tags: added: area-python
Changed in fuel:
importance: Undecided → High
Dmitry Pyzhov (dpyzhov) on 2016-03-14
tags: added: team-network
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → slava valyavskiy (slava-val-al)
tags: added: feature-sr-iov

Fix proposed to branch: master
Review: https://review.openstack.org/292469

Changed in fuel:
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/292469
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=7744d16dffe6a2d1fdc19468a22bff6459ff4cfb
Submitter: Jenkins
Branch: master

commit 7744d16dffe6a2d1fdc19468a22bff6459ff4cfb
Author: slava <email address hidden>
Date: Mon Mar 14 18:49:06 2016 +0300

    Add validation for 'sriov_numvfs' value

    Nailgun should accept only integer positive values for
    this parameter.

    Closes-Bug: #1556115
    Change-Id: I198079bfa15dd6020dfad063cf48b612bb68e539

Changed in fuel:
status: In Progress → Fix Committed

Verified on iso #190

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments