fuel plugins --install for plugin with duplicated task id

[Pavel Chechetin]

Given we have a plugin with a task_id collided with another task_id in the same plugin.
fpb doesn't complain about it, but it should've.

Even though fuel plugins --install prints errors about duplicated task_ids, the plugin ends up installed.
But it doesn't work, because information from it only partially was inserted into DB.
Exit code of such a faulty installation ends up 0.

ISO version: 8.0

Step to reproduce
  Install a plugins with duplicated task_id

Expected behavior:
   fpb doesn't build a plugin with duplicated task_id

   the plugin isn't installed

   fuel plugins returns non-zero exit code

Actual behavior:
    fpb doesn't complain about duplicated task_id and build plugin

    the plugin is installed

    fuel plugins returns 0

[Andriy Popovych (popovych-andrey)]

FPB is just generator of basic skeleton and validates correctness of plugin attributes structure not identifiers. Actually during build process FPB knows nothing about other plugins and it shouldn't.

[Pavel Chechetin (paulche)]

Hold on, its not about other plugins.
The issue above with collided task_id was inside one plugin.

[Ilya Kutukov (ikutukov)]

Validation is possible on both side, fuel and FPB, but if we want to detect problem early before plugin have been delivered it's better to detect id collision on FPB side.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/292018

[Vitalii Kulanov (vitaliy-t)]

Some comments to proposed fix that should be discussed:

Method 'check_deployment_tasks' in ValidatorV3 is not used for validating tasks.yaml file (in fpb).
(https://github.com/openstack/fuel-plugins/blob/master/fuel_plugin_builder/validators/validator_v3.py#L90-L116)
But there are two unittests in test_validator_v3.py that validates type schemas of deployment tasks (from tasks.yaml) that used check_deployment_tasks:
https://github.com/openstack/fuel-plugins/blob/master/fuel_plugin_builder/tests/test_validator_v3.py#L42
https://github.com/openstack/fuel-plugins/blob/master/fuel_plugin_builder/tests/test_validator_v3.py#L120

This is the only reason why we need to check 'id' key:
https://review.openstack.org/#/c/292018/1/fuel_plugin_builder/validators/validator_v3.py

[Vitalii Kulanov (vitaliy-t)]

Another point is that in the next fpb release ValidatorV4 will dealing with the only process of JSON schema validation (no business extra logic). So if we still need to validate uniqueness of task id in fpb we can try to do it: 1) by means of json-schema (not sure it is possible "in easy way" and, possible, requires schema redesign) or add extra business logic to fpb Validator.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Fuel DevOps Robot (<email address hidden>) on branch: master
Review: https://review.openstack.org/292018
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.