[fuel-library] cinder-volume daemons are stopped after role-based deployment. Task enable_cinder_volume_service (roles/cinder_enable.pp) will never be executed due to invalid description

[Andrey Bubyr]

Fuel 9.0. Task-based deployment was disabled, using role-based scheme.

Task 'enable_cinder_volume_service' which is responsible for starting 'cinder-volume' daemons at the end of cinder deployment (main stage) will never be executed because relies on 'role:' instead of 'groups:' in its description:

- id: enable_cinder_volume_service
  type: puppet
  version: 2.0.0
  role: [cinder, cinder-block-device]
  requires: [top-role-cinder]
  required_for: [deploy_end]
  parameters:
    puppet_manifest: /etc/puppet/modules/osnailyfacter/modular/roles/enable_cinder.pp
    puppet_modules: /etc/puppet/modules
    timeout: 3600
    cwd: /

https://github.com/openstack/fuel-library/blob/master/deployment/puppet/osnailyfacter/modular/roles/tasks.yaml#L44

So in result we have stopped cinder-volume services on all 'cinder' nodes.

This regression was brought up by this change:
https://review.openstack.org/#/c/281871/

Please replace
role: [cinder, cinder-block-device]
on
groups: [cinder, cinder-block-device]

Please take care about supporting role-based deployment in future because such kind of issues is very hard to debug

[Stanislaw Bogatkin (sbogatkin)]

It was changed for enable_compute already, so no need new one for compute.

[Stanislaw Bogatkin (sbogatkin)]

Set as 'invalid' for 8.0 due to the fact that fix caused regression was never merged into 8.0 codebase.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/288349

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/288349
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=73ee7d1b1fe157e37bfffb071359cedab453159e
Submitter: Jenkins
Branch: master

commit 73ee7d1b1fe157e37bfffb071359cedab453159e
Author: Stanislaw Bogatkin <email address hidden>
Date: Fri Mar 4 13:12:57 2016 +0300

    Rename role to groups in enable_cinder task

    In role-based deployments 'role' and 'groups' entities aren't the
    same as in task-based deployment, so we need to support old naming
    in case of users will prefer role-based deployments.

    Change-Id: I197c34d0b9ba2af36ed3b86df8bac5de2a4ec7ea
    Closes-Bug: #1553049

[ElenaRossokhina (esolomina)]

Verified on iso#324
cat /etc/fuel_build_id:
 324
cat /etc/fuel_build_number:
 324
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-release-9.0.0-1.mos6344.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8682.noarch
 network-checker-9.0.0-1.mos72.x86_64
 fuel-mirror-9.0.0-1.mos135.noarch
 fuel-openstack-metadata-9.0.0-1.mos8682.noarch
 fuel-notify-9.0.0-1.mos8356.noarch
 fuel-ostf-9.0.0-1.mos934.noarch
 python-fuelclient-9.0.0-1.mos314.noarch
 fuelmenu-9.0.0-1.mos270.noarch
 fuel-9.0.0-1.mos6344.noarch
 fuel-utils-9.0.0-1.mos8356.noarch
 fuel-nailgun-9.0.0-1.mos8682.noarch
 rubygem-astute-9.0.0-1.mos742.noarch
 fuel-library9.0-9.0.0-1.mos8356.noarch
 shotgun-9.0.0-1.mos88.noarch
 fuel-agent-9.0.0-1.mos276.noarch
 fuel-ui-9.0.0-1.mos2682.noarch
 fuel-setup-9.0.0-1.mos6344.noarch
 nailgun-mcagents-9.0.0-1.mos742.noarch
 fuel-misc-9.0.0-1.mos8356.noarch
 python-packetary-9.0.0-1.mos135.noarch
 fuel-bootstrap-cli-9.0.0-1.mos276.noarch
 fuel-migrate-9.0.0-1.mos8356.noarch