Invocation of functions from cli_base with remote parameter starts to fail with TypeError

Bug #1547195 reported by Tatyanka
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Critical
Tatyanka

Bug Description

https://github.com/openstack/fuel-qa/commit/1b2fb68e4cb14bbf57bd2b7064454c8482588350#diff-2819ec0138ce1328d55c9a20e308a070L53

This commit change signature of methods from cli_base, so that arg remote was deleted, so gate cli tests start to fail with type error

ERROR: Revert snapshot, apply changes from review and deploy
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jenkins/venv-nailgun-tests-2.9/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/home/jenkins/venv-nailgun-tests-2.9/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/home/jenkins/venv-nailgun-tests-2.9/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/home/jenkins/workspace/master.custom.pkgs.ubuntu/fuel-qa/fuelweb_test/helpers/decorators.py", line 83, in wrapper
    result = func(*args, **kwargs)
  File "/home/jenkins/workspace/master.custom.pkgs.ubuntu/fuel-qa/gates_tests/tests/test_review_in_fuel_client.py", line 161, in review_fuel_cli_one_node_deploy
    self.update_cli_network_configuration(cluster_id, remote)
  File "/home/jenkins/workspace/master.custom.pkgs.ubuntu/fuel-qa/fuelweb_test/__init__.py", line 59, in wrapped
    result = func(*args, **kwargs)
TypeError: update_cli_network_configuration() takes exactly 2 arguments (3 given)

Tags: area-qa
Changed in fuel:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (master)

Fix proposed to branch: master
Review: https://review.openstack.org/282033

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (master)

Reviewed: https://review.openstack.org/282033
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=982ff75f964411606fb2d90db8dedb5a3f814a51
Submitter: Jenkins
Branch: master

commit 982ff75f964411606fb2d90db8dedb5a3f814a51
Author: Tatyana Leontovich <email address hidden>
Date: Thu Feb 18 21:42:14 2016 +0200

    Fix type error in usage of func from cli_base

    Methods signatures in tests.cli_base.py were changed.
    So gate tests start to fail with type error,
    according to it missed to be updated.

    Change-Id: Ib4dfec08dcdb5e249505187bb6ebaeb9d6715abe
    Closes-Bug: #1547195

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-qa (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/282232

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-qa (master)

Reviewed: https://review.openstack.org/282232
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=333b4c319813c2353cdb1827e0f8862e450ec954
Submitter: Jenkins
Branch: master

commit 333b4c319813c2353cdb1827e0f8862e450ec954
Author: Tatyana Leontovich <email address hidden>
Date: Fri Feb 19 10:42:24 2016 +0200

    Fix type error in test_cli.py

    Methods signatures in tests.cli_base.py were changed.
    So we need to update it usage in test_cli.py

    Change-Id: If22c32f1bba34fc73a0ea8afe4e59f53b7242657
    Related-Bug: #1547195

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.