Need to rid of LegacyRoleResolver from nailgun

Bug #1546175 reported by Bulat Gaifullin
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Maciej Kwiek

Bug Description

The 2 implementation of role resolver is used now.
nailgun.utils.role_resolver#RoleResolver supports regular expressions for field role and groups, it is used in graph and task_based_deployment.

orchestrator.task_serialiser#LegacyRoleResolver does not support regular expressions and now used by default in plugins_serialiser and task_serialiser.

Since LegacyRoleResolver does not support regular expressions, it causes bugs that related to using regular expressions in field 'groups' of tasks from plugins.

Need to drop LegacyRoleResolver and replaces all usages with RoleResolver.

Changed in fuel:
status: New → Confirmed
tags: added: tech-debt
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Maciej Kwiek (maciej-iai)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/281138

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/281138
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=5bac79d0922992d0318f3015cff4d720d5474a71
Submitter: Jenkins
Branch: master

commit 5bac79d0922992d0318f3015cff4d720d5474a71
Author: Maciej Kwiek <email address hidden>
Date: Wed Feb 17 10:33:56 2016 +0100

    Remove LegacyRoleResolver

    LegacyRoleResolver is removed and replaced with RoleResolver.

    RoleResolver is created once where before it was created several times
    in a loop.

    Also, typo in StandardConfigRolesHook class name is fixed.

    Change-Id: Iccddec8948b47aa7441395af25782904f3ea7836
    Closes-bug: 1546175

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/282266

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/282266
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=2534d212807bbb9d3ddc115f5606923eca2b67fe
Submitter: Jenkins
Branch: master

commit 2534d212807bbb9d3ddc115f5606923eca2b67fe
Author: Bulat Gaifullin <email address hidden>
Date: Fri Feb 19 13:37:06 2016 +0300

    Fixed passing role_resolver to serialisers

    The role_resolver should be pass to serialisers as keyword argument,
    because each serialiser may have its own optional parameters
    (for example UploadConfiguration). There is no guarantee that positional
    arguments will map keywords arguments properly.

    Change-Id: Ic40013fbfa37e5db199d7464c24fa58029dac12d
    Closes-bug: 1546175

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.