Function get_ssl_property needs to be rewritten

Bug #1546077 reported by Stanislaw Bogatkin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Confirmed
Medium
Stanislaw Bogatkin
Mitaka
Won't Fix
Medium
Stanislaw Bogatkin
Newton
Confirmed
Medium
Stanislaw Bogatkin

Bug Description

Fuel-library function deployment/puppet/osnailyfacter/lib/puppet/parser/functions/get_ssl_property.rb should be rewritten to:

* not use Class inside a function. It should move to explicit module
* not try to be all-in-one function. We need separate function to getting protocol, separate for getting hostname and so on. It will lead to smaller functions that will be easier to read and understand
* remove some unusual notation like !!x==x (need to implement sort of equivalent of is_a?(Boolean ) instead)

Maciej Relewicz (rlu)
Changed in fuel:
status: New → Confirmed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.