Cluster has 'new' status after deployment

[Julia Aranovich]

STR:

1) create default environment and add some nodes
2) start 'provisioning' task for the environment (UI sends PUT /api/clusters/<cluster_id>/provision request with empty data to start the task). All the environment nodes will be provisioned.
3) start 'deployment' task for the environment (UI sends PUT /api/clusters/<cluster_id>/deploy request with empty data to start the task). All the environment nodes will be deployed.
4) check the environment status

Expected result: the environment status should be 'operational', as well as all nodes are deployed
Actual result: the environment status is 'new'. At the same time the environment has is_locked == true attribute.

[Ihor Kalnytskyi (ikalnytskyi)]

Hm.. I think it wasn't a bug. You see, by design we do not operate with cluster statuses on such low-level API calls like provision or deploy of selected nodes, and you use precisely them.

I think it should be discussed, because otherwise some use-cases may be broken.

[Evgeniy L (rustyrobot)]

+1 to Igor, the thing is it mustn't be operational, because with separate provisioning/deployment you easily may get unoperational cluster, even if separate deploy/provision succeed.
From year to year we are coming to a conclusion that cluster status should be calculated based on statuses of the nodes in the cluster.
And we will probably need to introduce some different status, to show, that the env is not new, and at the same time it's not ready.

[Dmitry Pyzhov (dpyzhov)]

I guess there are other cases. For example when we remove nodes in 'Error' state from partially deployed cluster. I hope you take them into account.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/279404

[Aleksey Kasatkin (alekseyk-ru)]

We have a corresponding story already:

https://bugs.launchpad.net/fuel/+bug/1449086

http://lists.openstack.org/pipermail/openstack-dev/2015-May/064580.html

Should we mark current bug as duplicate of 1449086 ?

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/284557

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/279404
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=72499871b7a0c89915d4fa5d91d12b332e0c9624
Submitter: Jenkins
Branch: master

commit 72499871b7a0c89915d4fa5d91d12b332e0c9624
Author: Bulat Gaifullin <email address hidden>
Date: Fri Feb 12 10:41:25 2016 +0300

    Fixed cluster state transitions

    Added new status for cluster:
    * partially_deployed - the nodes of cluster has different statuses.

    Change-Id: I5be8c4ed5f58e2c6545a7f06b8eab1ae37c8575f
    Closes-Bug: 1542201

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/286538

[OpenStack Infra (hudson-openstack)]

Change abandoned by Kate Pimenova (<email address hidden>) on branch: master
Review: https://review.openstack.org/284557
Reason: commit moved to fuel-ui repo

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/286538
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=3caf308458b564ef9b0178b326fd7ac7bd85deb5
Submitter: Jenkins
Branch: master

commit 3caf308458b564ef9b0178b326fd7ac7bd85deb5
Author: Kate Pimenova <email address hidden>
Date: Tue Mar 1 15:19:14 2016 +0300

    UI changes for partially_deployed cluster status

    Related-bug: #1542201

    Change-Id: I52b4c0db59088b6518a79292d9737be83732adca

[Mikhail Samoylov (msamoylov)]

Verified on fuel ISO #490