Misleading provision task message

[Julia Aranovich]

When user starts provisioning for a particular set of nodes, i.e. UI sends the following request:
PUT /api/clusters/<cluster_id>/provision?nodes=<node_id>,<node_id>

The task completed with the following message: "Provision of environment xxx is done."

BUT the expected text is smth like "Provision of N environment nodes is done" (where N - number of provisioned nodes) in case of provisioning of a part of the environment nodes.

The same text is in an appropriate notification after the task completed.

The same issue is applicable to 'deployment' task, when user wants to deploy a set of environment nodes:
PUT /api/clusters/<cluster_id>/deploy?nodes=<node_id>,<node_id>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/279025

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/279025
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=bef4d846030757cfe407c32e715c5197cb559137
Submitter: Jenkins
Branch: master

commit bef4d846030757cfe407c32e715c5197cb559137
Author: Bulat Gaifullin <email address hidden>
Date: Thu Feb 11 15:32:27 2016 +0300

    Fixed misleading provision task message

    In case if not all nodes are provisioned/deployed message will be
    shows message that only part of nodes in expected state, otherwise
    shows that whole cluster in expected state.
    Also fixed calculating status of task is based on all nodes from cluster,
    now only affected nodes are used to calculate task status.
    Also fixed truncate of stack on exception handling in fake tasks

    Change-Id: Icdb36e2e6a732becbb48d02b5c087922ecb3b7a8
    Closes-Bug: 1542196

[Grigory Mikhailov (gmikhailov)]

Verified on #fuel-9.0-mos-509 iso.
True provision task message is observed.

[root@nailgun ~]# shotgun2 short-report
cat /etc/fuel_build_id: 509
cat /etc/fuel_build_number: 509
cat /etc/fuel_release: 9.0
cat /etc/fuel_openstack_version: mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-release-9.0.0-1.mos6349.noarch
 fuel-misc-9.0.0-1.mos8460.noarch
 python-packetary-9.0.0-1.mos140.noarch
 fuel-bootstrap-cli-9.0.0-1.mos285.noarch
 fuel-migrate-9.0.0-1.mos8460.noarch
 rubygem-astute-9.0.0-1.mos750.noarch
 fuel-mirror-9.0.0-1.mos140.noarch
 shotgun-9.0.0-1.mos90.noarch
 fuel-openstack-metadata-9.0.0-1.mos8743.noarch
 fuel-notify-9.0.0-1.mos8460.noarch
 nailgun-mcagents-9.0.0-1.mos750.noarch
 python-fuelclient-9.0.0-1.mos325.noarch
 fuel-9.0.0-1.mos6349.noarch
 fuel-utils-9.0.0-1.mos8460.noarch
 fuel-setup-9.0.0-1.mos6349.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8743.noarch
 fuel-library9.0-9.0.0-1.mos8460.noarch
 network-checker-9.0.0-1.mos74.x86_64
 fuel-agent-9.0.0-1.mos285.noarch
 fuel-ui-9.0.0-1.mos2717.noarch
 fuel-ostf-9.0.0-1.mos936.noarch
 fuelmenu-9.0.0-1.mos274.noarch
 fuel-nailgun-9.0.0-1.mos8743.noarch