Sending PUT request for updating node with invalid role prevent other tabs from opening

[Alexander Gromov]

If we try to send PUT request for updating node and set the role of the node to invalid value than we will not able to open other tabs.

Steps to reproduce:
1. Create environment with default values
2. Send PUT request to fuel to add new node with invalid value for role parameter. For example we can do that the following way:
    1) git clone https://github.com/Mirantis/mos-ci-deployment-scripts
    2) cd mos-ci-deployment-scripts/mos-components-ci/componentspython
    3) go to python interpretator (python)
    4) type the following strings:
        import nailgun_client as fuel
        client = fuel.NailgunClient(<ip>)
        node_data = [{
            "cluster_id": 1,
            "id": 1,
            "pending_addition": True,
            "pending_deletion": False,
            "pending_roles": ["invalid"],
            "name": "invalid" }]
        client.update_nodes(node_data)
3. As result fuel UI will be broken (we will not be able to go to any tabs).

Only UI is affected. We can send another request and indicate correct value for role and UI will work again.

[Ivan Ponomarev (ivanzipfer)]

Please provide Fuel ISO version

[Alexander Gromov (agromov)]

I have used #485 ISO (fuel-8.0-485-2016-01-26_07-56-06.iso).

[Dmitry Pyzhov (dpyzhov)]

Looks like issue on nailgun side. Also we should check why our UI fails to open tab on incorrect response from the server.

[Dmitry Pyzhov (dpyzhov)]

Maybe we should track UI issue as a separate bug.

[Bug Checker Bot (bug-checker)]

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

actual result

expected result

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/300534

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/300534
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=9edc5b07ca2c46c0e295a12b0d692b5a67967a06
Submitter: Jenkins
Branch: master

commit 9edc5b07ca2c46c0e295a12b0d692b5a67967a06
Author: Dmitry Guryanov <email address hidden>
Date: Fri Apr 1 15:04:07 2016 +0300

    validate pending_roles for Node

    When you do PUT request to NodeCollectionHandler
    it's possible to provide some unexistent roles,
    which results in broken UI. Because it tries to
    get some info about these roles to display.

    Fixes-bug: #1539733
    Change-Id: I3b5070ca36589be3fa8488717e99823e253089ca