centos7 puppet3.8 gate facter issue blocking all patches

[Bogdan Dobrelya]

There is a gate failing for each patch on review. Example: http://logs.openstack.org/14/270714/1/check/gate-fuel-library-puppet-unit-3.8-dsvm-centos7/01fc0d6/console.html#_2016-01-22_10_17_22_781

Note that the cento7 gate puppet3.4 is not affected.
I cannot reproduce the problem with Ubuntu 14.04, but it is reproducable on the Centos7 box.
The RC seems the custom ceph module fact 'osd_devices_list'.
The both environments use the same puppet, bundled gems and ruby versions: ruby-2.0.0-p598, puppet 3.8.5.

For the ceph module rspec, the diff for installed gems of the puppet 3.8.5 against the 3.4.0 is:
 Gems included by the bundle:
- * CFPropertyList (2.2.8)
   * bundler (1.11.2)
   * diff-lcs (1.2.5)
- * facter (2.4.5) #puppet 3.8.5 case
+ * facter (1.7.6) #puppet 3.4.0 case
   * hiera (1.3.4)
   * json_pure (1.8.3)
   * metaclass (0.0.4)
   * mocha (1.1.0)
- * puppet (3.8.5)
+ * puppet (3.4.0)
   * puppet-lint (0.3.2)
   * puppet-syntax (2.1.0)
   * puppetlabs_spec_helper (1.0.1)
   * rake (10.5.0)
+ * rgen (0.6.6)
   * rspec (3.4.0)
   * rspec-core (3.4.1)
   * rspec-expectations (3.4.0)

So it is something to the facter (2.4.5) which makes the osd_devices_list fact working only for Ubuntu env...

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/271521

[Alex Schultz (alex-schultz)]

Created upstream bug report for the facter change, https://tickets.puppetlabs.com/browse/FACT-1318

[Maksim Malchuk (mmalchuk)]

Review: https://review.openstack.org/271521
will fix the CI, but broke the BVT

[Maksim Malchuk (mmalchuk)]

custom BVT is broken because of other problems, so this fix should be merged

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/271821

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/271521
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=35fdff42f705873e6ab5fe8e87959e125e25b2b7
Submitter: Jenkins
Branch: master

commit 35fdff42f705873e6ab5fe8e87959e125e25b2b7
Author: Maksim Malchuk <email address hidden>
Date: Fri Jan 22 23:56:26 2016 +0300

    Facter 'osd_devices_list' sgdisk issue

    Facter 'osd_devices_list' shouldn't return nil.

    Change-Id: Iaf96c040a38f89052b062715ee3be2eaf3921235
    Closes-Bug: #1537102

[OpenStack Infra (hudson-openstack)]

Change abandoned by Kyrylo Galanov (<email address hidden>) on branch: master
Review: https://review.openstack.org/271438

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/271821
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=59621be94dcb8f241e167a8197dc421559f2e455
Submitter: Jenkins
Branch: stable/8.0

commit 59621be94dcb8f241e167a8197dc421559f2e455
Author: Maksim Malchuk <email address hidden>
Date: Fri Jan 22 23:56:26 2016 +0300

    Facter 'osd_devices_list' sgdisk issue

    Facter 'osd_devices_list' shouldn't return nil.

    Change-Id: Iaf96c040a38f89052b062715ee3be2eaf3921235
    (cherrypicked from commit 35fdff42f705873e6ab5fe8e87959e125e25b2b7)
    Closes-Bug: #1537102

[Tatyanka (tatyana-leontovich)]

verified 509 iso