Fuel for OpenStack

[fuel-octane] get_patch_port_action works incorrectly for version 2014.2-6.0

Bug #1536182 reported by Roman Sokolkov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Oleg S. Gelbukh
Fuel for OpenStack 6.1-updates
8.0.x
Fix Committed
Medium
Oleg S. Gelbukh
Fuel for OpenStack 8.0

Bug Description

"get_patch_port_action" uses LooseVersion to compare Fuel versions,
but in case Fuel "2014.2-6.0" it works improperly

From LooseVersion standpoint:
2014.2-6.0 is greater(newer) than 2014.2.2-6.1

But in reality:
2014.2-6.0 is smaller(older) than 2014.2.2-6.1

How to reproduce:

On fuel master open python interpreter

>>> from distutils.version import LooseVersion
>>> version = "2014.2-6.0"
>>> if version < LooseVersion('2014.2.2-6.1'):
... print "Works correct for %s" % version
... else:
... print "Works incorrect for %s" % version
...
Works incorrect for 2014.2-6.0

See original description
Maciej Relewicz (rlu)
Changed in fuel:
assignee: nobody → Fuel Octane Dev Team (fuel-octane)
milestone: none → 6.1-updates
importance: Undecided → Medium
status: New → Confirmed
Roman Sokolkov (rsokolkov)
Changed in fuel:
assignee: Fuel Octane Dev Team (fuel-octane) → Roman Sokolkov (rsokolkov)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (master)

Fix proposed to branch: master
Review: https://review.openstack.org/270202

Changed in fuel:
assignee: Roman Sokolkov (rsokolkov) → Oleg S. Gelbukh (gelbuhos)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (stable/7.0)

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/270203

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-octane (stable/7.0)

Change abandoned by rsokolkov (<email address hidden>) on branch: stable/7.0
Review: https://review.openstack.org/270203
Reason: Duplicate of https://review.openstack.org/#/c/270202/1

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-octane (master)

Reviewed: https://review.openstack.org/270202
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=f6616e07ed952167ce11d33d47c5349bd4cd8542
Submitter: Jenkins
Branch: master

commit f6616e07ed952167ce11d33d47c5349bd4cd8542
Author: Oleg Gelbukh <email address hidden>
Date: Wed Jan 20 14:00:55 2016 +0000

    Use only Fuel release version to determine default port provider

    Only Fuel release version defines the default port provider. Exclude
    OpenStack release version from the comparison. Use StrictVersion instead
    of LooseVersion.

    Change-Id: I9927c006d6842fc3cca7f5bd068402eb70acea4e
    Closes-bug: 1536182

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-octane (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/271205

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (stable/8.0)

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/271298

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (stable/7.0)

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/271299

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-octane (stable/8.0)

Reviewed: https://review.openstack.org/271298
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=8c88dbfb9a8a76cf1009f55779d04117e9e177ab
Submitter: Jenkins
Branch: stable/8.0

commit 8c88dbfb9a8a76cf1009f55779d04117e9e177ab
Author: Oleg Gelbukh <email address hidden>
Date: Wed Jan 20 14:00:55 2016 +0000

    Use only Fuel release version to determine default port provider

    Only Fuel release version defines the default port provider. Exclude
    OpenStack release version from the comparison. Use StrictVersion instead
    of LooseVersion.

    Change-Id: I9927c006d6842fc3cca7f5bd068402eb70acea4e
    Closes-bug: 1536182
    (cherry picked from commit f6616e07ed952167ce11d33d47c5349bd4cd8542)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-octane (stable/7.0)

Reviewed: https://review.openstack.org/271299
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=008152464b07342bbb323c0030689523fb56d063
Submitter: Jenkins
Branch: stable/7.0

commit 008152464b07342bbb323c0030689523fb56d063
Author: Oleg Gelbukh <email address hidden>
Date: Wed Jan 20 14:00:55 2016 +0000

    Use only Fuel release version to determine default port provider

    Only Fuel release version defines the default port provider. Exclude
    OpenStack release version from the comparison. Use StrictVersion instead
    of LooseVersion.

    Change-Id: I9927c006d6842fc3cca7f5bd068402eb70acea4e
    Closes-bug: 1536182
    (cherry picked from commit f6616e07ed952167ce11d33d47c5349bd4cd8542)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-octane (master)

Reviewed: https://review.openstack.org/271205
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=41b2cbcaeb591e9733d5a2db461186a08ca825d6
Submitter: Jenkins
Branch: master

commit 41b2cbcaeb591e9733d5a2db461186a08ca825d6
Author: Oleg Gelbukh <email address hidden>
Date: Fri Jan 22 09:43:34 2016 +0000

    Add tests for get_patch_port_action function

    Test proper identification of release and provider for port
    in network schema.

    Change-Id: Ia89b1aa060c900e5ef83f76d257b1f284c059f88
    Related-bug: 1536182

Nastya Urlapova (aurlapova)
tags: added: dev-to-verify
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-octane (stable/8.0)

Related fix proposed to branch: stable/8.0
Review: https://review.openstack.org/282277

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-octane (stable/7.0)

Related fix proposed to branch: stable/7.0
Review: https://review.openstack.org/282279

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-octane (stable/8.0)

Reviewed: https://review.openstack.org/282277
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=9244220b233d014ab6342c818b2d75b7d6ac1ab4
Submitter: Jenkins
Branch: stable/8.0

commit 9244220b233d014ab6342c818b2d75b7d6ac1ab4
Author: Oleg Gelbukh <email address hidden>
Date: Fri Jan 22 09:43:34 2016 +0000

    Add tests for get_patch_port_action function

    Test proper identification of release and provider for port
    in network schema.

    Change-Id: Ia89b1aa060c900e5ef83f76d257b1f284c059f88
    Related-bug: 1536182
    (cherry picked from commit 41b2cbcaeb591e9733d5a2db461186a08ca825d6)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-octane (stable/7.0)

Reviewed: https://review.openstack.org/282279
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=15d286b4ea75e744845ac41b5fb8bb4a6da5387b
Submitter: Jenkins
Branch: stable/7.0

commit 15d286b4ea75e744845ac41b5fb8bb4a6da5387b
Author: Oleg Gelbukh <email address hidden>
Date: Fri Jan 22 09:43:34 2016 +0000

    Add tests for get_patch_port_action function

    Test proper identification of release and provider for port
    in network schema.

    Change-Id: Ia89b1aa060c900e5ef83f76d257b1f284c059f88
    Related-bug: 1536182
    (cherry picked from commit 41b2cbcaeb591e9733d5a2db461186a08ca825d6)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.