Fuel for OpenStack

Unnecessary calls to commit() in NetworkManager

Bug #1535937 reported by Ryan Moe
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Low
Ryan Moe
Fuel for OpenStack 9.0

Bug Description

There are a few places in network/manager.py and related tests which call commit() when flush() is suitable.

Tags: tech-debt
Ryan Moe (rmoe)
Changed in fuel:
assignee: nobody → Ryan Moe (rmoe)
importance: Undecided → Low
tags: added: tech-debt
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/269917

Changed in fuel:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/269917
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=f7906450be3b528c9fa9276fda4671b6710f1b5f
Submitter: Jenkins
Branch: master

commit f7906450be3b528c9fa9276fda4671b6710f1b5f
Author: Ryan Moe <email address hidden>
Date: Tue Jan 19 15:15:49 2016 -0800

    Remove unnecessary commit() calls in NetworkManager

    It is not necessary to manage transactions from inside NetworkManager.

    Change-Id: I4fed85399eb7309fb3c8c2612ee0a7f8c369b06d
    Closes-bug: #1535937

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.