Node disk configuration reset's to default after resetting cluster

[Artem Hrechanychenko]

Since to https://docs.mirantis.com/openstack/fuel/fuel-7.0/user-guide.html#reset-environment

#Reset Environment

Click this button to reset the whole environment back to the state it was in right before the "Deploy changes" button was first clicked.

My state before "deploy changes" - non-default size of "vdc", so I expect to see this state after Reset procedure completed

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "429"
  build_id: "429"
  fuel-nailgun_sha: "12b15b2351e250af41cc0b10d63a50c198fe77d8"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "df16d41cd7a9445cf82ad9fd8f0d53824711fcd8"
  fuel-nailgun-agent_sha: "92ebd5ade6fab60897761bfa084aefc320bff246"
  astute_sha: "c7ca63a49216744e0bfdfff5cb527556aad2e2a5"
  fuel-library_sha: "3eaf4f4a9b88b287a10cc19e9ce6a62298cc4013"
  fuel-ostf_sha: "214e794835acc7aa0c1c5de936e93696a90bb57a"
  fuel-mirror_sha: "b62f3cce5321fd570c6589bc2684eab994c3f3f2"
  fuelmenu_sha: "85de57080a18fda18e5325f06eaf654b1b931592"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "9f0ba4577915ce1e77f5dc9c639a5ef66ca45896"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "e8e36cff332644576d7853c80b8a53d5b955420a"

Steps to reproduce

Scenario:
1. Create new environment
2. Choose Neutron, TUN
3. Add 5 controller
4. Add 1 compute
5. Add 2 cinder
6. Change default partitioning for cinder nodes for 'vdc'
7. Verify networks
8. Deploy the environment
9. Verify networks
10. Run OSTF tests
11. Reset cluster, Change openstack username, password, tenant and re-deploy

Actual result:

After Reset cluster, cinder vdc size restored to default

[Michael Semenov (msemenov)]

Scale env with 200 nodes was idle due to this bug during 3 days. May be it's not critical for product, but it's definitely critical for scale testing - we have very strict schedule.

Other QA teams also facing this bug from time to time. So, please raise priority and fix it ASAP.

[Oleksandr Minakov (oleksandr-minakov)]

I'm not sure is this bug or feature, because in code we have clearly set volumes to default on reset node
https://github.com/openstack/fuel-web/blob/9c9d7a88a373bf03b2d13c1204e6452577a12175/nailgun/nailgun/extensions/volume_manager/extension.py#L91-L93

Of course we can just skip method set_default_node_volumes() during node reset, but this is not the best solution. It looks like hack.