UI ignores plugin restrictions

[Julia Aranovich]

Plugin version restrictions are not taken into account when rendering plugin settings.

For example, if plugin version has the following metadata restriction:

 "attributes_metadata": {
               "metadata": {
                   "restrictions": [
                       {
                           "condition": "settings:common.use_vcenter.value == false or cluster:net_provider != 'neutron'",
                           "action": "hide",
                           "strict": false
                       }
                   ]
               },
              ...
          }

It will be shown on UI in both neutron and nova-network environments despite on the restriction.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/267567

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/266872
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=1cbe85b96f4d2fdd370ef73bc19835380f276da3
Submitter: Jenkins
Branch: master

commit 1cbe85b96f4d2fdd370ef73bc19835380f276da3
Author: Julia Aranovich <email address hidden>
Date: Wed Jan 13 12:52:17 2016 +0300

    Remove expandedRestrictions cache

    The cache removed because it does not support plugin versioning
    (it always keeps restrictions from the last plugin version
    for plugin settings with the same name accross verions).
    Also, the cache does not bring many benefits, but can cause bugs
    as an additional source of true for setting restrictions

    Closes-Bug: #1534094

    Change-Id: I8405d6673ec632288fee18032652a5bbca68cad4

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/267567
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=4d0cad05ce212374d4f0f3bba35c5ca47db48deb
Submitter: Jenkins
Branch: stable/8.0

commit 4d0cad05ce212374d4f0f3bba35c5ca47db48deb
Author: Julia Aranovich <email address hidden>
Date: Wed Jan 13 12:52:17 2016 +0300

    Remove expandedRestrictions cache

    The cache removed because it does not support plugin versioning
    (it always keeps restrictions from the last plugin version
    for plugin settings with the same name accross verions).
    Also, the cache does not bring many benefits, but can cause bugs
    as an additional source of true for setting restrictions

    Closes-Bug: #1534094

    Change-Id: I8405d6673ec632288fee18032652a5bbca68cad4

[Dmitriy Kruglov (dkruglov)]

Verified on MOS 8.0, build 481. The issue is fixed.

ISO details:
VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "481"
  build_id: "481"
  fuel-nailgun_sha: "ae949905142507f2cb446071783731468f34a572"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "481ed135de2cb5060cac3795428625befdd1d814"
  fuel-nailgun-agent_sha: "b2bb466fd5bd92da614cdbd819d6999c510ebfb1"
  astute_sha: "b81577a5b7857c4be8748492bae1dec2fa89b446"
  fuel-library_sha: "420c6fa5f8cb51f3322d95113f783967bde9836e"
  fuel-ostf_sha: "ab5fd151fc6c1aa0b35bc2023631b1f4836ecd61"
  fuel-mirror_sha: "b62f3cce5321fd570c6589bc2684eab994c3f3f2"
  fuelmenu_sha: "fac143f4dfa75785758e72afbdc029693e94ff2b"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "9f0ba4577915ce1e77f5dc9c639a5ef66ca45896"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "6c6b088a3d52dd0eaf43d59f3a3a149c93a07e7e"