osnailyfacter/mysql modules contain index/key assignements not compatible with puppet4

[Alex Schultz]

Attempting to assign an unassigned index/key to a hash in puppet is not compatible with puppet4. We need to fix this to properly support puppet4.

Specifically this is occurring in mysql and osnailyfacter. Check the gate-fuel-library-puppet-syntax-4-dsvm-centos7 job logs.

2016-01-11 14:35:28.246 | Could not parse for environment *root*: Illegal attempt to assign via [index/key]. Not an assignable reference at /home/jenkins/workspace/gate-fuel-library-puppet-syntax-4-dsvm-centos7/deployment/puppet/mysql/manifests/server.pp:112:5
2016-01-11 14:35:28.247 | Could not parse for environment *root*: Illegal attempt to assign via [index/key]. Not an assignable reference at /home/jenkins/workspace/gate-fuel-library-puppet-syntax-4-dsvm-centos7/deployment/puppet/osnailyfacter/modular/roles/cinder.pp:117:3
2016-01-11 14:35:28.247 | Could not parse for environment *root*: Illegal attempt to assign via [index/key]. Not an assignable reference at /home/jenkins/workspace/gate-fuel-library-puppet-syntax-4-dsvm-centos7/deployment/puppet/osnailyfacter/modular/roles/compute.pp:123:3

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/267366

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/267373

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/267411

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/267373
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=09fc5a622831830492711f6effd17c335ab49c56
Submitter: Jenkins
Branch: master

commit 09fc5a622831830492711f6effd17c335ab49c56
Author: Maksim Malchuk <email address hidden>
Date: Thu Jan 14 11:06:53 2016 +0300

    Puppet4 propper support in the osnailyfacter/cinder

    * Adapt to Puppet 4
    * Code cleanup

    Change-Id: I6558afc04b6d68e4802eab83de526c0a3d1a3aae
    Partial-Bug: #1533359

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/267366
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=64110deddc72b9926844b61207891fa9947f868f
Submitter: Jenkins
Branch: master

commit 64110deddc72b9926844b61207891fa9947f868f
Author: Maksim Malchuk <email address hidden>
Date: Thu Jan 14 10:47:09 2016 +0300

    Puppet4 propper support in the mysql module

    * Adapt to Puppet 4
    * Code cleanup

    Change-Id: I540ac66098434aea231aa7711e90f7e109ea3761
    Partial-Bug: #1533359

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/267411
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=54a0513916f4238ac196855ad6456255e39d5a66
Submitter: Jenkins
Branch: master

commit 54a0513916f4238ac196855ad6456255e39d5a66
Author: Maksim Malchuk <email address hidden>
Date: Thu Jan 14 11:51:54 2016 +0300

    Puppet4 propper support in the osnailyfacter/compute

    * Adapt to Puppet 4
    * Code cleanup

    Change-Id: I237bcc8ee866cf166954de3954431234a67006dc
    Depends-On: I6558afc04b6d68e4802eab83de526c0a3d1a3aae
    Depends-On: I540ac66098434aea231aa7711e90f7e109ea3761
    Closes-Bug: #1533359