globals.pp has warning about mutating array/hash which is not compatible with puppet4

[Alex Schultz]

To properly support puppet4 and cleanup unnecessary warnings we need to address these issues in globals:

2015-12-31 22:58:17 WARNING The use of mutating operations on Array/Hash is deprecated at /etc/puppet/modules/osnailyfacter/modular/globals/globals.pp:402. See http://links.puppetlabs.com/puppet-mutation-deprecation
2015-12-31 22:58:17 WARNING The use of mutating operations on Array/Hash is deprecated at /etc/puppet/modules/osnailyfacter/modular/globals/globals.pp:376. See http://links.puppetlabs.com/puppet-mutation-deprecation
2015-12-31 22:58:17 WARNING The use of mutating operations on Array/Hash is deprecated at /etc/puppet/modules/osnailyfacter/modular/globals/globals.pp:375. See http://links.puppetlabs.com/puppet-mutation-deprecation
2015-12-31 22:58:17 WARNING The use of mutating operations on Array/Hash is deprecated at /etc/puppet/modules/osnailyfacter/modular/globals/globals.pp:374. See http://links.puppetlabs.com/puppet-mutation-deprecation
2015-12-31 22:58:17 WARNING The use of mutating operations on Array/Hash is deprecated at /etc/puppet/modules/osnailyfacter/modular/globals/globals.pp:373. See http://links.puppetlabs.com/puppet-mutation-deprecation
2015-12-31 22:58:17 WARNING The use of mutating operations on Array/Hash is deprecated at /etc/puppet/modules/osnailyfacter/modular/globals/globals.pp:273. See http://links.puppetlabs.com/puppet-mutation-deprecation
2015-12-31 22:55:03 WARNING The use of mutating operations on Array/Hash is deprecated at /etc/puppet/modules/osnailyfacter/modular/globals/globals.pp:402. See http://links.puppetlabs.com/puppet-mutation-deprecation
2015-12-31 22:55:03 WARNING The use of mutating operations on Array/Hash is deprecated at /etc/puppet/modules/osnailyfacter/modular/globals/globals.pp:376. See http://links.puppetlabs.com/puppet-mutation-deprecation
2015-12-31 22:55:03 WARNING The use of mutating operations on Array/Hash is deprecated at /etc/puppet/modules/osnailyfacter/modular/globals/globals.pp:375. See http://links.puppetlabs.com/puppet-mutation-deprecation
2015-12-31 22:55:03 WARNING The use of mutating operations on Array/Hash is deprecated at /etc/puppet/modules/osnailyfacter/modular/globals/globals.pp:374. See http://links.puppetlabs.com/puppet-mutation-deprecation
2015-12-31 22:55:03 WARNING The use of mutating operations on Array/Hash is deprecated at /etc/puppet/modules/osnailyfacter/modular/globals/globals.pp:373. See http://links.puppetlabs.com/puppet-mutation-deprecation
2015-12-31 22:55:03 WARNING The use of mutating operations on Array/Hash is deprecated at /etc/puppet/modules/osnailyfacter/modular/globals/globals.pp:273. See http://links.puppetlabs.com/puppet-mutation-deprecation
2015-12-31 22:36:52 WARNING The use of mutating operations on Array/Hash is deprecated at /etc/puppet/modules/osnailyfacter/modular/globals/globals.pp:402. See http://links.puppetlabs.com/puppet-mutation-deprecation
2015-12-31 22:36:52 WARNING The use of mutating operations on Array/Hash is deprecated at /etc/puppet/modules/osnailyfacter/modular/globals/globals.pp:376. See http://links.puppetlabs.com/puppet-mutation-deprecation
2015-12-31 22:36:52 WARNING The use of mutating operations on Array/Hash is deprecated at /etc/puppet/modules/osnailyfacter/modular/globals/globals.pp:375. See http://links.puppetlabs.com/puppet-mutation-deprecation
2015-12-31 22:36:52 WARNING The use of mutating operations on Array/Hash is deprecated at /etc/puppet/modules/osnailyfacter/modular/globals/globals.pp:374. See http://links.puppetlabs.com/puppet-mutation-deprecation
2015-12-31 22:36:52 WARNING The use of mutating operations on Array/Hash is deprecated at /etc/puppet/modules/osnailyfacter/modular/globals/globals.pp:373. See http://links.puppetlabs.com/puppet-mutation-deprecation
2015-12-31 22:36:52 WARNING The use of mutating operations on Array/Hash is deprecated at /etc/puppet/modules/osnailyfacter/modular/globals/globals.pp:273. See http://links.puppetlabs.com/puppet-mutation-deprecation
2015-12-31 22:35:33 WARNING The use of mutating operations on Array/Hash is deprecated at /etc/puppet/modules/osnailyfacter/modular/globals/globals.pp:402. See http://links.puppetlabs.com/puppet-mutation-deprecation
2015-12-31 22:35:33 WARNING The use of mutating operations on Array/Hash is deprecated at /etc/puppet/modules/osnailyfacter/modular/globals/globals.pp:376. See http://links.puppetlabs.com/puppet-mutation-deprecation
2015-12-31 22:35:33 WARNING The use of mutating operations on Array/Hash is deprecated at /etc/puppet/modules/osnailyfacter/modular/globals/globals.pp:375. See http://links.puppetlabs.com/puppet-mutation-deprecation
2015-12-31 22:35:33 WARNING The use of mutating operations on Array/Hash is deprecated at /etc/puppet/modules/osnailyfacter/modular/globals/globals.pp:374. See http://links.puppetlabs.com/puppet-mutation-deprecation
2015-12-31 22:35:33 WARNING The use of mutating operations on Array/Hash is deprecated at /etc/puppet/modules/osnailyfacter/modular/globals/globals.pp:373. See http://links.puppetlabs.com/puppet-mutation-deprecation
2015-12-31 22:35:33 WARNING The use of mutating operations on Array/Hash is deprecated at /etc/puppet/modules/osnailyfacter/modular/globals/globals.pp:273. See http://links.puppetlabs.com/puppet-mutation-deprecation

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "368"
  build_id: "368"
  fuel-nailgun_sha: "20ff1666ea6171a085051ffd77444c52f972b7e7"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "1d2f6bc1123b9364ba65b41afcc0608662bb25b9"
  fuel-nailgun-agent_sha: "92ebd5ade6fab60897761bfa084aefc320bff246"
  astute_sha: "c7ca63a49216744e0bfdfff5cb527556aad2e2a5"
  fuel-library_sha: "6ec90013ed909997097563cddc762937dc873eb3"
  fuel-ostf_sha: "889ddb0f1a4fa5f839fd4ea0c0017a3c181aa0c1"
  fuel-mirror_sha: "8bb8c70efc61bcf633e02d6054dbf5ec8dcf6699"
  fuelmenu_sha: "824f6d3ebdc10daf2f7195c82a8ca66da5abee99"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "9f0ba4577915ce1e77f5dc9c639a5ef66ca45896"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "5dd650b541d40251e07afde4072d948be577dc0c"

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/262839

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/262839
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=a2fadb2ef64bf1a00911c00eaffd92b345ff4d47
Submitter: Jenkins
Branch: master

commit a2fadb2ef64bf1a00911c00eaffd92b345ff4d47
Author: Maksim Malchuk <email address hidden>
Date: Fri Jan 1 04:36:42 2016 +0300

    Properly support of Puppet4 in the globals.pp

    This commit fixes mutating operations on array/hash types.
    This commit contains some cleanups according to the styling guide.

    Change-Id: I4a109e0cf7c136c451a9d1758e4a4beb7ef323d9
    Closes-Bug: #1530394