Disable stringify_facts in puppet

Bug #1526782 reported by Bartłomiej Piotrowski
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Bartłomiej Piotrowski

Bug Description

By default Puppet enables stringify_facts. It can lead to weird behavior, assuming a fact, that supposedly returns an array. E.g.:

Facter: ["/", "/boot", "/var", "/var/log"]
As exposed in Puppet: "[\"/\", \"/boot\", \"/var\", \"/var/log\"]"

stringify_fact is already disabled in Puppet 4, so it makes sense to do it now to save us from possible problems in the future.

tags: added: area-library
tags: added: feature
Changed in fuel:
status: Triaged → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/263221

Changed in fuel:
status: Confirmed → In Progress
Changed in fuel:
assignee: Bartłomiej Piotrowski (bpiotrowski) → Michael Polenchuk (mpolenchuk)
Changed in fuel:
assignee: Michael Polenchuk (mpolenchuk) → Bartłomiej Piotrowski (bpiotrowski)
Changed in fuel:
assignee: Bartłomiej Piotrowski (bpiotrowski) → Michael Polenchuk (mpolenchuk)
Changed in fuel:
assignee: Michael Polenchuk (mpolenchuk) → Bartłomiej Piotrowski (bpiotrowski)
Revision history for this message
Michael Polenchuk (mpolenchuk) wrote :

Additionally the configuration of puppet has to be updated on gate w/ fuel-library-puppet-units and on fuel-ci hosts w/ fuellib-noop tests as well.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-agent (master)

Fix proposed to branch: master
Review: https://review.openstack.org/297036

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-library (master)

Change abandoned by Bartłomiej Piotrowski (<email address hidden>) on branch: master
Review: https://review.openstack.org/263221
Reason: Superseded by https://review.openstack.org/#/c/297036/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-agent (master)

Reviewed: https://review.openstack.org/297036
Committed: https://git.openstack.org/cgit/openstack/fuel-agent/commit/?id=f862fb86adf0fb4d483f65f7f5e6734a6219502f
Submitter: Jenkins
Branch: master

commit f862fb86adf0fb4d483f65f7f5e6734a6219502f
Author: Bartłomiej Piotrowski <email address hidden>
Date: Thu Mar 24 12:28:01 2016 +0100

    Disable stringify_facts on managed nodes

    By default Puppet enables stringify_facts. It can lead to weird behavior,
    assuming a fact, that supposedly returns an array. E.g.:

    Facter: ["/", "/boot", "/var", "/var/log"]
    As exposed in Puppet: "[\"/\", \"/boot\", \"/var\", \"/var/log\"]"

    It is already disabled in Puppet 4, so it makes sense to do it now to save
    us from possible problems in the future.

    Change-Id: Ib70ae937165ddb2968c9e4346434f18778b31714
    Closes-Bug: 1526782

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.