[library] database task is not idempotent

[Roman Sokolkov]

"database" task should be refactored in favor idempotency.

Environment:
- MOS 7.0, MOS 8.0
- Any environment

How to reproduce:
puppet apply --noop /etc/puppet/modules/osnailyfacter/modular/database/database.pp

Expected result:
grep out_of_sync /var/lib/puppet/state/last_run_summary.yaml
    out_of_sync: 0

Actual result:
root@node-14:~# grep out_of_sync /var/lib/puppet/state/last_run_summary.yaml
    out_of_sync: 9

Details:
Puppet output - http://paste.openstack.org/show/481463/

Part of this bug should be fixed by: https://bugs.launchpad.net/fuel/+bug/1524731

[Michael Polenchuk (mpolenchuk)]

Will be resolved by "Switch to upstream mysql and galera modules" (https://review.openstack.org/267232)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/267232
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=041aa989a0a701622f06782197413288bdffb19e
Submitter: Jenkins
Branch: master

commit 041aa989a0a701622f06782197413288bdffb19e
Author: Alex Schultz <email address hidden>
Date: Wed Jan 13 16:46:39 2016 -0700

    Switch to upstream mysql and galera modules

    This change switches out our mysql and galera modules for the
    puppetlabs-mysql and michaeltchapman-galera.

    This change includes the following updates:
     - mysql module removed
     - galera module removed
     - mysql hacks were removed from openstacklib module
       https://review.fuel-infra.org/#/c/16445/
     - galera::client moved to openstack::galera::client
     - db modulars updated to use openstack::galera::client
     - database task updated to use galera module
     - create cluster::mysql to do pacemaker configuration for mysql
     - remove osnailyfacter::mysql_user
     - additional database noop tests
     - additional unit tests

    Change-Id: Idd0957c677b87a2d8794e993417ef9e2f0ddf4a6
    Implements-Blueprint: mysql-galera-librarian
    Closes-Bug: #1524747

[Sergey Novikov (snovikov)]

Verified on 9.0 MOS iso #366

there is only one resource change "File[/root/.my.cnf]", but as I know, it's expected change