[library][idempotency] /etc/rsyslog.d/haproxy.conf should be created by logging task

[Roman Sokolkov]

/etc/rsyslog.d/haproxy.conf created by cluster-haproxy task, but to keep idempotent it should be created by "logging" task.

Environment:
- Deployed controller
- Actual both for MOS 7.0, MOS 8.0

For example, on deployed environment i'm starting only "logging" task on controller.

Expected result:
- No changes in /etc/rsyslog.d directory

Actual result:
- /etc/rsyslog.d/haproxy.conf file removed.

Details:
puppet apply --noop /etc/puppet/modules/osnailyfacter/modular/logging/logging.pp
Notice: Scope(Class[main]): MODULAR: logging.pp
Notice: Compiled catalog for node-14.domain.tld in environment production in 0.74 seconds
Notice: /Stage[main]/Rsyslog::Client/File[/etc/rsyslog.d/haproxy.conf]/ensure: current_value file, should be absent (noop)
Notice: /etc/rsyslog.d/: Would have triggered 'refresh' from 1 events
Notice: Class[Rsyslog::Client]: Would have triggered 'refresh' from 1 events
Notice: Class[Rsyslog::Service]: Would have triggered 'refresh' from 1 events
Notice: /Stage[main]/Rsyslog::Service/Service[rsyslog]: Would have triggered 'refresh' from 1 events
Notice: Class[Rsyslog::Service]: Would have triggered 'refresh' from 1 events
Notice: Stage[main]: Would have triggered 'refresh' from 2 events
Notice: Finished catalog run in 1.56 seconds

[Bogdan Dobrelya (bogdando)]

Sorry but the current description looks pointless. Why haproxy conf should be ever related to the logging conf?

[Bogdan Dobrelya (bogdando)]

Sorry, I misinterpreted the haproxy conf here is actually one for Rsyslog and not for HAProxy itself. Seems valid then. Logging tasks shall configure logging configs.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/257832

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/257832
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=29d65b95b1fe53855a15260a391718fdb02dc385
Submitter: Jenkins
Branch: master

commit 29d65b95b1fe53855a15260a391718fdb02dc385
Author: Bartłomiej Piotrowski <email address hidden>
Date: Tue Dec 15 12:06:30 2015 +0100

    Fix idempotence of logging task

    The logging task removes all files from /etc/rsyslog.d, while
    cluster-haproxy (executed later in the deployment graph) wants to put
    its rsyslog configuration there. This commit moves HAProxy rsyslog
    configuration to cluster::haproxy::rsyslog class, and defines it in both
    logging task and cluster:haproxy class.

    Change-Id: I2b450ef8d8de4fc9d41ada458af26ab91b9c871e
    Closes-Bug: 1524687

[ElenaRossokhina (esolomina)]

Verified using suggested initial scenario on iso#555
[root@nailgun ~]# cat /etc/fuel/version.yaml
VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "555"
  build_id: "555"
  fuel-nailgun_sha: "ed2e0cde96ae7bc064e689f7409470e69c57772e"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "658be72c4b42d3e1436b86ac4567ab914bfb451b"
  fuel-nailgun-agent_sha: "b2bb466fd5bd92da614cdbd819d6999c510ebfb1"
  astute_sha: "b81577a5b7857c4be8748492bae1dec2fa89b446"
  fuel-library_sha: "33634ec27be77ecfb0b56b7e07497ad86d1fdcd3"
  fuel-ostf_sha: "3bc76a63a9e7d195ff34eadc29552f4235fa6c52"
  fuel-mirror_sha: "fb45b80d7bee5899d931f926e5c9512e2b442749"
  fuelmenu_sha: "78ffc73065a9674b707c081d128cb7eea611474f"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "a43cf96cd9532f10794dce736350bf5bed350e9d"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "d605bcbabf315382d56d0ce8143458be67c53434"