globals task is not idempotent

[Roman Sokolkov]

"globals" task on every run removes and creates /etc/hiera/globals.yaml.

For example, in case noop we'r getting /etc/hiera/globals.yaml REMOVED.

puppet apply --noop /etc/puppet/modules/osnailyfacter/modular/globals/globals.pp

Expected result:
1) grep out_of_sync /var/lib/puppet/state/last_run_summary.yaml gives "out_of_sync: 0"
2) /etc/hiera/globals.yaml will be untouched.

Actual result:
1) grep out_of_sync /var/lib/puppet/state/last_run_summary.yaml gives "out_of_sync: 1"
2) /etc/hiera/globals.yaml REMOVED

[Bogdan Dobrelya (bogdando)]

That is done so by design, globals should remove and recreate things on each run.