Fuel for OpenStack

tweaks::ubuntu_service_override is not idempotent

Bug #1524327 reported by Roman Sokolkov
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Bartłomiej Piotrowski
Fuel for OpenStack 8.0

Bug Description

I've found that "tweaks::ubuntu_service_override" changes on every run.

Actual result:
For example, for glance task i'm always getting 4 resources "out_of_sync". http://paste.openstack.org/show/481307/

Expected result:
"tweaks::ubuntu_service_override" shouldn't change on every run if were no REAL state change.

Roman Prykhodchenko (romcheg)
Changed in fuel:
importance: Undecided → Medium
assignee: nobody → Fuel Library Team (fuel-library)
milestone: none → 8.0
status: New → Confirmed
Roman Prykhodchenko (romcheg)
tags: added: area-library
Pavel Chechetin (paulche)
summary: - ubuntu_service_override is not idempotent
+ tweaks::ubuntu_service_override is not idempotent
Michael Polenchuk (mpolenchuk)
Changed in fuel:
assignee: Fuel Library Team (fuel-library) → Michael Polenchuk (mpolenchuk)
Bartłomiej Piotrowski (bpiotrowski)
Changed in fuel:
assignee: Michael Polenchuk (mpolenchuk) → Bartłomiej Piotrowski (bpiotrowski)
Stanislaw Bogatkin (sbogatkin)
tags: added: team-bugfix
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/257902

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/257902
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=2668feccf6adce8d704f5a09536877bf9ccece5d
Submitter: Jenkins
Branch: master

commit 2668feccf6adce8d704f5a09536877bf9ccece5d
Author: Bartłomiej Piotrowski <email address hidden>
Date: Tue Dec 15 14:46:07 2015 +0100

    Fix idempotence of tweaks::ubuntu_service_override

    To achieve that, the commit adds custom function named is_pkg_installed,
    which uses dpkg-query or rpm to check the package existence. No service
    override magic happens if package is already installed.

    Co-Authored-By: Michael Polenchuk <email address hidden>
    Closes-Bug: 1524327
    Change-Id: I771a3f80808edd104f7ff1dc2dfd9e130f7b64f7

Changed in fuel:
status: In Progress → Fix Committed
Nastya Urlapova (aurlapova)
tags: added: dev-to-verify
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.