Default node network group name should be capitalized

[Alexandra Morozova]

In OpenStack environments by default when only one node network group is present its name is 'default' it would be better to change it with 'Default'

[Aleksey Kasatkin (alekseyk-ru)]

This does not break anything. It is just about appearance. I'm not sure it is medium priority. Maybe, low? Moving to 9.0.

[Vitaly Kramskikh (vkramskikh)]

After merging https://review.openstack.org/#/c/261471/ we'll have "default" group name in UI (non-capitalized) which looks ugly :( Since it's just changing default name in DB schema, this change can barely break something, let's do it. Do changing priority to High

[Artem Roma (aroma-x)]

There yet is the place in Nailgun code where name of default group still matters [1]. There won't be any failure but logic of validation will process node group 'Default' in slightly different manner - particularly as if the name is not present in template ( in such case data from 'default' section will be used). IMO this will be a point of confusing for user who wants to utilize templates. Also, name of a group is nothing special but simply a piece of data so I don't see why 'default' is more logically different or uglier than 'Default'. In any case user may always change the name for what is more suitable on his/her opinion. In addition why this has 'high' importance in the first place? Lets not exploit possibility to manipulate statuses as it has different purpose.

[1]: https://github.com/openstack/fuel-web/blob/master/nailgun/nailgun/task/task.py#l1429-l1433

[Artem Roma (aroma-x)]

Given my previous comment move this bug to invalid

[Vitaly Kramskikh (vkramskikh)]

I think it's high because without capitalizing it looks very ugly on the UI and without this fixed on the backed we will have to reintroduce capitalizing on the UI. If you still rely on hardcoded "default" group, it's not an excuse for not fixing this.

I've attached a screenshot of how this looks in the master. Everything else is capitalized, and "default" really looks very alien here.

[Vitaly Kramskikh (vkramskikh)]

Moved it back to confirmed - we really relied on this to be fixed in 8.0. If it's not possible to fix it - please tell us, we'll reintroduce capitalizing hack on the UI

[Dmitry Pyzhov (dpyzhov)]

Let's wait for @akasatkin's opinion on this bug

[Ihor Kalnytskyi (ikalnytskyi)]

It doesn't matter the fix is trivial or not, appearance (especially that's about capitalized letter or not) could not be considered as a High Bug.

[Aleksey Kasatkin (alekseyk-ru)]

Agree with Igor.

For network templates: this feature (considering 'default' template for the rest of node groups) should be implemented in different manner (e.g. having a special key-value, like 'default':True) or removed at all. Now it is hard to use it as the name of node group can be equal to this key (and we have 'default' node group by default).

[Bug Checker Bot (bug-checker)]

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

actual result

expected result

steps to reproduce

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/301254

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/302260

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/303352

[OpenStack Infra (hudson-openstack)]

Change abandoned by Fuel DevOps Robot (<email address hidden>) on branch: master
Review: https://review.openstack.org/301254
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Fuel DevOps Robot (<email address hidden>) on branch: master
Review: https://review.openstack.org/303352
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Javier (jvalinas)]

This change needs to update functional tests as well.
I don't have the environment to run the tests properly.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Andreas Jaeger (<email address hidden>) on branch: master
Review: https://review.opendev.org/302260
Reason: Self-approving to retire repository.