Name is required for the field for detach-keystone plugin on 'Settings' tab

Bug #1516973 reported by Anastasia Palkina
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Confirmed
Medium
Fuel Python (Deprecated)

Bug Description

1. Install and build detach-keystone and detach-database plugins

git clone https://github.com/openstack/fuel-plugin-detach-keystone
git clone https://github.com/openstack/fuel-plugin-detach-database

2. Create new environment (by default)
3. Open 'Settings' tab
4. Open "Other" segment
5. Name is required for the field for detach-keystone plugin (see screen)

"release_versions": {"2015.1.0-8.0": {"VERSION": {"fuel-upgrade_sha": "1e894e26d4e1423a9b0d66abd6a79505f4175ff6", "fuel-createmirror_sha": "22a7aacd95bbdca69f9e0f08b70facabdec8fb28", "shotgun_sha": "c377d163519f6d10b69a654019d6086ba5f14edc", "api": "1.0", "fuelmain_sha": "266f9b374934c64629a84b5146632cc0de70ac91", "astute_sha": "959b06c5ef8143125efd1727d350c050a922eb12", "fuel-ostf_sha": "9690a2de829d3b063ed1e64b0b10dde39f711dc0", "openstack_version": "2015.1.0-8.0", "build_id": "171", "fuelmenu_sha": "06bbcebed6c8d0b0f9279e2997d2f958c800e98c", "build_number": "171", "fuel-library_sha": "31aa9fb129a8b8739f8ca6ea186caa3c9f46820f", "fuel-nailgun-agent_sha": "3e9d17211d65c80bf97c8d83979979f6c7feb687", "fuel-nailgun_sha": "37cfc3206d9c0b510112ea7a7f461e40f8c08d6a", "fuel-agent_sha": "61f741f4d89a3f1095dd8b494f82695fb69153d6", "production": "docker", "network-checker_sha": "a57e1d69acb5e765eb22cab0251c589cd76f51da", "feature_groups": ["mirantis"], "release": "8.0", "python-fuelclient_sha": "e685d68c1c0d0fa0491a250f07d9c3a8d0f9608c"}}}, "fuel-upgrade_sha": "1e894e26d4e1423a9b0d66abd6a79505f4175ff6", "fuel-createmirror_sha": "22a7aacd95bbdca69f9e0f08b70facabdec8fb28", "shotgun_sha": "c377d163519f6d10b69a654019d6086ba5f14edc", "api": "1.0", "fuelmain_sha": "266f9b374934c64629a84b5146632cc0de70ac91", "astute_sha": "959b06c5ef8143125efd1727d350c050a922eb12", "fuel-ostf_sha": "9690a2de829d3b063ed1e64b0b10dde39f711dc0", "openstack_version": "2015.1.0-8.0", "build_id": "171", "fuelmenu_sha": "06bbcebed6c8d0b0f9279e2997d2f958c800e98c", "build_number": "171", "auth_required": true, "fuel-library_sha": "31aa9fb129a8b8739f8ca6ea186caa3c9f46820f", "fuel-nailgun-agent_sha": "3e9d17211d65c80bf97c8d83979979f6c7feb687", "fuel-nailgun_sha": "37cfc3206d9c0b510112ea7a7f461e40f8c08d6a", "fuel-agent_sha": "61f741f4d89a3f1095dd8b494f82695fb69153d6", "production": "docker", "network-checker_sha": "a57e1d69acb5e765eb22cab0251c589cd76f51da", "feature_groups": ["mirantis"], "release": "8.0", "python-fuelclient_sha": "e685d68c1c0d0fa0491a250f07d9c3a8d0f9608c"

Revision history for this message
Anastasia Palkina (apalkina) wrote :
tags: added: area-plugins feature-plugins
Revision history for this message
Ilya Kutukov (ikutukov) wrote :

I'm not sure that it is not the result of plug-in misconfiguration.
If it so, please, re-assign to the fuel-python team.

Changed in fuel:
status: New → Confirmed
Changed in fuel:
assignee: Fuel UI Team (fuel-ui) → Matthew Mosesohn (raytrac3r)
Revision history for this message
Matthew Mosesohn (raytrac3r) wrote :

There's no new input field, but now the current fuel UI logic presents this extra garbage. It's now slightly invalid UI code:
https://github.com/openstack/fuel-plugin-detach-keystone/blob/master/environment_config.yaml#L2-L5
https://github.com/openstack/fuel-plugin-detach-database/blob/master/environment_config.yaml#L2-L4
Can you advise what should be fixed so that the condition for the plugin still works?

Attached is a screenshot from an ISO generated on 2015-11-12 (custom one)

Revision history for this message
Julia Aranovich (jkirnosova) wrote :

Everything looks Ok on my local env, if I just add plugins yaml code and default metadata (toggleable = True, enabled = False, weight = 70): http://paste.openstack.org/show/icjuobPemfSTX5iEJ39D/
Also, there is no plugin version radio buttons on my screenshot

Can you provide GET /api/clisters/x/attributes response for the env with the plugins installed?

Is it possible that smth was changed in https://github.com/openstack/fuel-web/blob/master/nailgun/nailgun/plugins/manager.py#L30-L153

Revision history for this message
Julia Aranovich (jkirnosova) wrote :

This is not UI code issue definitely.
The problem in plugin parser code.

Plugin metadata from the plugin yaml https://github.com/openstack/fuel-plugin-detach-keystone/blob/master/environment_config.yaml#L2-L5 is not merged into result plugin setting section metadata in /api/clusters/x/attributes response: http://s9.postimg.org/8x8cqdcan/Screenshot_from_2015_11_19_19_29_46.png

and it rendered by ui code like a usual setting. It has no type, no name attributes, so default text input without name is rendered

Revision history for this message
Matthew Mosesohn (raytrac3r) wrote :

Based on Julia's comment, it looks like this metadata field is needed to set a condition parameter for the plugin and the parser should be fixed. Additionally, marking this as 8.0-regression because it was introduced based on new functionality.

tags: added: regression-8.0
Changed in fuel:
assignee: Matthew Mosesohn (raytrac3r) → Fuel Python Team (fuel-python)
Revision history for this message
Ihor Kalnytskyi (ikalnytskyi) wrote :

Looks like a duplicate of bug 1518993.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.