Nailgun should deny upload of network.yaml changes without modification of meta.notation

Bug #1514916 reported by Tatyanka
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Nikolay Tymtsiv
Mitaka
Won't Fix
Medium
Fuel Python (Deprecated)
Newton
Fix Committed
Medium
Nikolay Tymtsiv

Bug Description

Steps:
Deploy master node
Bootstrap slaves from default nodegroup
3. Create cluster with Neutron VXLAN and custom nodegroup
4. Download network configuration using
     fuel --debug --env {id} --json --dir {dir} network -d
5. Update network.json with customized
IP ranges for management and storage networks
 6. Put new json on master node and update
 environment network configuration with it
http://paste.openstack.org/show/478445/
7. Download net data one more time and verify that new IP ranges are applied for network config

Actual:
changes were not applied, success on put request

Expected:
According update on notation was missed here it would be great to see 400 bad error on attempts to put invalid data

Changed in fuel:
status: New → Confirmed
Changed in fuel:
milestone: 8.0 → 9.0
Dmitry Pyzhov (dpyzhov)
tags: added: team-network
Dmitry Pyzhov (dpyzhov)
summary: - Need to return error for case if user try to uplad changed network.yaml
- but without change into meta.notation
+ Nailgun should deny upload of network.yaml changes without modification
+ of meta.notation
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/338304

Changed in fuel:
assignee: Fuel Sustaining (fuel-sustaining-team) → Nikolay Tymtsiv (ntymtsiv)
status: Confirmed → In Progress
Revision history for this message
Aleksey Kasatkin (alekseyk-ru) wrote :

It's the same for use_gateway case. Let's include checking of use_gateway also.

Revision history for this message
Nikolay Tymtsiv (ntymtsiv) wrote :

Do you mean setting "meta.use_gateway=True" and do not specify "gateway"? Could you clarify this?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/338304
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=55dd7c77d8e568e073323e3b85312d10c4ba47c3
Submitter: Jenkins
Branch: master

commit 55dd7c77d8e568e073323e3b85312d10c4ba47c3
Author: nikolay_tymtsiv <email address hidden>
Date: Wed Jul 6 16:23:54 2016 +0300

    Deny changes ip_ranges without meta.notation

    If ip_ranges value updated in networks.yaml and
    notation was not changed to 'ip_ranges' from 'cidr'
    or gatwey was changed but meta.use_gateway is False
    nailgun will deny this request

    Closes-Bug: #1514916

     Author: ntymtsiv <email address hidden>
    Change-Id: Ic60ffd0ed81a69277577893cb9819adad8741f4a

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-web 10.0.0rc1

This issue was fixed in the openstack/fuel-web 10.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-web 10.0.0

This issue was fixed in the openstack/fuel-web 10.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.